Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 2364963003: Revert of Ship async functions (Closed)

Created:
4 years, 2 months ago by adamk
Modified:
4 years, 2 months ago
Reviewers:
caitp, Dan Ehrenberg
CC:
Michael Hablich, v8-reviews_googlegroups.com, kozy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Ship async functions (patchset #2 id:20001 of https://codereview.chromium.org/2356943002/ ) Reason for revert: Triggers TSAN errors on Linux64: https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11901 Original issue's description: > Ship async functions > > Intent to ship discussion: > https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY > > BUG=v8:4483 > > Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 > Cr-Commit-Position: refs/heads/master@{#39697} TBR=caitp@igalia.com,littledan@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Committed: https://crrev.com/a4354b6c15fd9dbde2677efdf81fbc99ff0cf3e0 Cr-Commit-Position: refs/heads/master@{#39699}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (3 generated)
adamk
Created Revert of Ship async functions
4 years, 2 months ago (2016-09-24 00:25:24 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364963003/1
4 years, 2 months ago (2016-09-24 00:25:33 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-09-24 00:25:44 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/a4354b6c15fd9dbde2677efdf81fbc99ff0cf3e0 Cr-Commit-Position: refs/heads/master@{#39699}
4 years, 2 months ago (2016-09-24 00:26:04 UTC) #7
Dan Ehrenberg
4 years, 2 months ago (2016-09-24 02:08:33 UTC) #8
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2363093003/ by littledan@chromium.org.

The reason for reverting is: Fixed underlying cause of TSAN issue; trying again
while watching the bots..

Powered by Google App Engine
This is Rietveld 408576698