Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 2363093003: Reland of Ship async functions (Closed)

Created:
4 years, 3 months ago by Dan Ehrenberg
Modified:
4 years, 3 months ago
Reviewers:
caitp, adamk
CC:
Michael Hablich, v8-reviews_googlegroups.com, kozy
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Ship async functions (patchset #1 id:1 of https://codereview.chromium.org/2364963003/ ) Reason for revert: Fixed underlying cause of TSAN issue; trying again while watching the bots. Original issue's description: > Revert of Ship async functions (patchset #2 id:20001 of https://codereview.chromium.org/2356943002/ ) > > Reason for revert: > Triggers TSAN errors on Linux64: > > https://build.chromium.org/p/client.v8/builders/V8%20Linux64%20TSAN/builds/11901 > > Original issue's description: > > Ship async functions > > > > Intent to ship discussion: > > https://groups.google.com/forum/#!topic/v8-users/gwpcEIrgIZY > > > > BUG=v8:4483 > > > > Committed: https://crrev.com/9f7540a0ec6333e7c71615609fe29274d9b7a4c5 > > Cr-Commit-Position: refs/heads/master@{#39697} > > TBR=caitp@igalia.com,littledan@chromium.org > # Skipping CQ checks because original CL landed less than 1 days ago. > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=v8:4483 > > Committed: https://crrev.com/a4354b6c15fd9dbde2677efdf81fbc99ff0cf3e0 > Cr-Commit-Position: refs/heads/master@{#39699} TBR=caitp@igalia.com,adamk@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4483 Committed: https://crrev.com/97cdf9f978e971df8a463fef7525bb942d305796 Cr-Commit-Position: refs/heads/master@{#39702}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/flag-definitions.h View 2 chunks +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Dan Ehrenberg
Created Reland of Ship async functions
4 years, 3 months ago (2016-09-24 02:08:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2363093003/1
4 years, 3 months ago (2016-09-24 02:08:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 3 months ago (2016-09-24 02:08:46 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/97cdf9f978e971df8a463fef7525bb942d305796 Cr-Commit-Position: refs/heads/master@{#39702}
4 years, 3 months ago (2016-09-24 02:09:02 UTC) #6
Dan Ehrenberg
4 years, 3 months ago (2016-09-24 02:50:05 UTC) #7
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2365113003/ by littledan@chromium.org.

The reason for reverting is: TSAN failures still happening; need to investigate
more..

Powered by Google App Engine
This is Rietveld 408576698