Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issue 2364653002: Buildbot build json grpc endpoint (Closed)

Created:
4 years, 3 months ago by Ryan Tseng
Modified:
4 years, 3 months ago
Reviewers:
estaab, martiniss, hinoka
CC:
andrew.wang, chromium-reviews, infra-reviews+luci-go_chromium.org, M-A Ruel, tandrii+luci-go_chromium.org, todd
Target Ref:
refs/heads/master
Project:
luci-go
Visibility:
Public.

Description

Buildbot build json grpc endpoint This grpc endpoint fetches and returns a buildbot json. Also refactored build() so that it expects buildNum to be an int. BUG=642461 Committed: https://github.com/luci/luci-go/commit/252dd6dd5887a25127c6ff6dfe6c9e59cc27109d

Patch Set 1 #

Patch Set 2 : Pass tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+408 lines, -256 lines) Patch
M milo/api/proto/buildbot.proto View 2 chunks +14 lines, -0 lines 0 comments Download
M milo/api/proto/buildbot.pb.go View 8 chunks +91 lines, -17 lines 0 comments Download
M milo/api/proto/buildbotserver_dec.go View 1 chunk +15 lines, -0 lines 0 comments Download
M milo/api/proto/pb.discovery.go View 1 chunk +239 lines, -217 lines 0 comments Download
M milo/appengine/buildbot/build.go View 4 chunks +6 lines, -15 lines 0 comments Download
M milo/appengine/buildbot/build_test.go View 2 chunks +2 lines, -2 lines 0 comments Download
M milo/appengine/buildbot/grpc.go View 1 chunk +28 lines, -0 lines 0 comments Download
M milo/appengine/buildbot/html.go View 2 chunks +9 lines, -1 line 0 comments Download
M milo/appengine/buildbot/html_data.go View 1 2 chunks +4 lines, -4 lines 0 comments Download

Messages

Total messages: 16 (12 generated)
hinoka
ptal. Demo: https://1134-aaa1422-tainted-hinoka-dot-luci-milo.appspot.com/rpcexplorer/services/milo.Buildbot/GetBuildbotBuildJSON?request={%20%20%20%20%22master%22:%20%22chromium.perf%22,%20%20%20%20%22builder%22:%20%22Win%2010%20High-DPI%20Perf%20(2)%22,%20%20%20%20%22build_num%22:%20261}
4 years, 3 months ago (2016-09-22 17:25:10 UTC) #5
martiniss
lgtm code looks pretty simple, hooray!
4 years, 3 months ago (2016-09-22 17:50:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2364653002/20001
4 years, 3 months ago (2016-09-22 18:03:54 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-22 18:07:51 UTC) #16
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://github.com/luci/luci-go/commit/252dd6dd5887a25127c6ff6dfe6c9e59cc27109d

Powered by Google App Engine
This is Rietveld 408576698