Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(641)

Unified Diff: milo/appengine/buildbot/build_test.go

Issue 2364653002: Buildbot build json grpc endpoint (Closed)
Patch Set: Pass tests Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/build.go ('k') | milo/appengine/buildbot/grpc.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/build_test.go
diff --git a/milo/appengine/buildbot/build_test.go b/milo/appengine/buildbot/build_test.go
index cf750d03cb4c56b784dd8d6341eeb9637c21d906..3dc90f58236fd33d9c9aec2b702374fe9572892f 100644
--- a/milo/appengine/buildbot/build_test.go
+++ b/milo/appengine/buildbot/build_test.go
@@ -71,7 +71,7 @@ func TestBuild(t *testing.T) {
Convey(fmt.Sprintf("Test Case: %s/%s", tc.builder, tc.build), func() {
build, err := build(c, "debug", tc.builder, tc.build)
So(err, ShouldBeNil)
- fname := fmt.Sprintf("%s.%s.build.json", tc.builder, tc.build)
+ fname := fmt.Sprintf("%s.%d.build.json", tc.builder, tc.build)
So(build, shouldMatchExpectationsFor, fname)
})
}
@@ -83,7 +83,7 @@ func TestBuild(t *testing.T) {
Number: 1,
Internal: true,
})
- b, err := getBuild(c, "fake", "fake", "1")
+ b, err := getBuild(c, "fake", "fake", 1)
So(b, ShouldBeNil)
So(err, ShouldResemble, miloerror.Error{
Message: "Cannot fetch project buildbot-internal:\ndatastore: no such entity",
« no previous file with comments | « milo/appengine/buildbot/build.go ('k') | milo/appengine/buildbot/grpc.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698