Buildbot build json grpc endpoint

milo/appengine/buildbot/build.go

 // Copyright 2016 The LUCI Authors. All rights reserved.
 // Use of this source code is governed under the Apache License, Version 2.0
 // that can be found in the LICENSE file.
 
 package buildbot
 
 import (
         "encoding/json"
         "fmt"
         "io/ioutil"
         "net/http"
         "path/filepath"
         "sort"
-        "strconv"
         "strings"
         "time"
 
         ds "github.com/luci/gae/service/datastore"
         "github.com/luci/luci-go/common/logging"
         "github.com/luci/luci-go/milo/api/resp"
         "github.com/luci/luci-go/milo/appengine/settings"
         "github.com/luci/luci-go/milo/common/miloerror"
         "golang.org/x/net/context"
 )
 
 var errBuildNotFound = miloerror.Error{
         Message: "Build not found",
         Code:    http.StatusNotFound,
 }
 
 // getBuild fetches a buildbot build from the datastore and checks ACLs.
-func getBuild(c context.Context, master, builder, buildNum string) (*buildbotBuild, error) {
+func getBuild(c context.Context, master, builder string, buildNum int) (*buildbotBuild, error) {
         result := &buildbotBuild{
                 Master:      master,
                 Buildername: builder,
+                Number:      buildNum,
         }
 
-        num, err := strconv.Atoi(buildNum)
-        if err != nil {
-                return nil, miloerror.Error{
-                        Message: fmt.Sprintf("%s does not look like a number", buildNum),
-                        Code:    http.StatusBadRequest,
-                }
-        }
-        result.Number = num
-
-        err = ds.Get(c, result)
+        err := ds.Get(c, result)
         switch {
         case err == ds.ErrNoSuchEntity:
                 return nil, errBuildNotFound
         case err != nil:
                 return nil, err
         }
         if result.Internal {
                 allowed, err := settings.IsAllowedInternal(c)
                 if err != nil {
                         return nil, err
@@ skipping 343 matching lines @@
                                 Label: fmt.Sprintf("Issue %d", issue),
                                 URL:   fmt.Sprintf("%s/%d", rietveld, issue),
                         }
                 } else {
                         logging.Warningf(c, "Found issue but not rietveld property.")
                 }
         }
         return ss
 }
 
-func getDebugBuild(c context.Context, builder, buildNum string) (*buildbotBuild, error) {
-        fname := fmt.Sprintf("%s.%s.json", builder, buildNum)
+func getDebugBuild(c context.Context, builder string, buildNum int) (*buildbotBuild, error) {
+        fname := fmt.Sprintf("%s.%d.json", builder, buildNum)
         // ../buildbot below assumes that
         // - this code is not executed by tests outside of this dir
         // - this dir is a sibling of frontend dir
         path := filepath.Join("..", "buildbot", "testdata", fname)
         raw, err := ioutil.ReadFile(path)
         if err != nil {
                 return nil, err
         }
         b := &buildbotBuild{}
         return b, json.Unmarshal(raw, b)
 }
 
 // build fetches a buildbot build and translates it into a miloBuild.
-func build(c context.Context, master, builder, buildNum string) (*resp.MiloBuild, error) {
+func build(c context.Context, master, builder string, buildNum int) (*resp.MiloBuild, error) {
         var b *buildbotBuild
         var err error
         if master == "debug" {
                 b, err = getDebugBuild(c, builder, buildNum)
         } else {
                 b, err = getBuild(c, master, builder, buildNum)
         }
         if err != nil {
                 return nil, err
         }
 
         // TODO(hinoka): Do all fields concurrently.
         return &resp.MiloBuild{
                 SourceStamp:   sourcestamp(c, b),
                 Summary:       summary(c, b),
                 Components:    components(b),
                 PropertyGroup: properties(b),
                 Blame:         blame(b),
         }, nil
 }