Issue 2351433002: Switch LocalBorderBoxProperties to store raw pointers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2351433002: Switch LocalBorderBoxProperties to store raw pointers (Closed)

Created:
4 years, 3 months ago by pdr.

Modified:
4 years, 3 months ago

Reviewers:

CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Switch LocalBorderBoxProperties to store raw pointers BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Total comments: 1

Created: 4 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+80 lines, -81 lines)			Patch
M	third_party/WebKit/Source/core/paint/ObjectPaintProperties.h	View	3 chunks	+21 lines, -20 lines	1 comment	Download
M	third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp	View	1 chunk	+14 lines, -6 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintInvalidator.cpp	View	2 chunks	+2 lines, -4 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp	View	1 chunk	+3 lines, -9 lines	0 comments	Download
M	third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp	View	12 chunks	+37 lines, -39 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

jbroman

4 years, 3 months ago (2016-09-21 15:23:17 UTC) #2

https://codereview.chromium.org/2351433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/2351433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:106: // this layout
object. It is needed becauase some property inherits from the containing block,
nit: s/becauase/because/

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages