Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Issue 2351433002: Switch LocalBorderBoxProperties to store raw pointers (Closed)

Created:
4 years, 3 months ago by pdr.
Modified:
4 years, 3 months ago
Reviewers:
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, slimming-paint-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch LocalBorderBoxProperties to store raw pointers BUG=645615 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+80 lines, -81 lines) Patch
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 3 chunks +21 lines, -20 lines 1 comment Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.cpp View 1 chunk +14 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 2 chunks +2 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 1 chunk +3 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 12 chunks +37 lines, -39 lines 0 comments Download

Messages

Total messages: 2 (1 generated)
jbroman
4 years, 3 months ago (2016-09-21 15:23:17 UTC) #2
https://codereview.chromium.org/2351433002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/paint/ObjectPaintProperties.h (right):

https://codereview.chromium.org/2351433002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/paint/ObjectPaintProperties.h:106: // this layout
object. It is needed becauase some property inherits from the containing block,
nit: s/becauase/because/

Powered by Google App Engine
This is Rietveld 408576698