Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(361)

Unified Diff: src/gpu/vk/GrVkCaps.h

Issue 2363773006: Add command buffer submits before copy calls in vulkan. (Closed)
Patch Set: change submit check to a cap Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | src/gpu/vk/GrVkCaps.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/gpu/vk/GrVkCaps.h
diff --git a/src/gpu/vk/GrVkCaps.h b/src/gpu/vk/GrVkCaps.h
index 8e8953e52294e829aa9b8cd66fc5931424ad5ab0..a4ce35aa03de7e1cc9e3ace6dcf91b61c5899bd8 100644
--- a/src/gpu/vk/GrVkCaps.h
+++ b/src/gpu/vk/GrVkCaps.h
@@ -74,6 +74,10 @@ public:
return fSupportsCopiesAsDraws;
}
+ bool mustSubmitCommandsBeforeCopyOp() const {
+ return fMustSubmitCommandsBeforeCopyOp;
+ }
+
/**
* Returns both a supported and most prefered stencil format to use in draws.
*/
@@ -86,6 +90,7 @@ public:
private:
enum VkVendor {
kQualcomm_VkVendor = 20803,
+ kNvidia_VkVendor = 4318,
};
void init(const GrContextOptions& contextOptions, const GrVkInterface* vkInterface,
@@ -135,6 +140,11 @@ private:
// Check whether we support using draws for copies.
bool fSupportsCopiesAsDraws;
+ // On Nvidia there is a current bug where we must the current command buffer before copy
+ // operations or else the copy will not happen. This includes copies, blits, resolves, and copy
+ // as draws.
+ bool fMustSubmitCommandsBeforeCopyOp;
+
typedef GrCaps INHERITED;
};
« no previous file with comments | « no previous file | src/gpu/vk/GrVkCaps.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698