Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 2367693002: [fullcodegen] Refactor code that calls load ICs. (Closed)

Created:
4 years, 3 months ago by Igor Sheludko
Modified:
4 years, 2 months ago
Reviewers:
mvstanton
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[fullcodegen] Refactor code that calls load ICs. BUG=v8:5408 Committed: https://crrev.com/43a09146bb92e216fb1674ff0ecea8581df91bd5 Cr-Commit-Position: refs/heads/master@{#39707}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -144 lines) Patch
M src/full-codegen/arm/full-codegen-arm.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/arm64/full-codegen-arm64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/full-codegen.h View 1 chunk +2 lines, -4 lines 0 comments Download
M src/full-codegen/full-codegen.cc View 5 chunks +25 lines, -16 lines 0 comments Download
M src/full-codegen/ia32/full-codegen-ia32.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/mips/full-codegen-mips.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/mips64/full-codegen-mips64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/ppc/full-codegen-ppc.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/s390/full-codegen-s390.cc View 1 chunk +0 lines, -12 lines 0 comments Download
M src/full-codegen/x64/full-codegen-x64.cc View 1 chunk +0 lines, -14 lines 0 comments Download
M src/full-codegen/x87/full-codegen-x87.cc View 1 chunk +0 lines, -14 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 22 (16 generated)
Igor Sheludko
PTAL
4 years, 3 months ago (2016-09-23 09:03:06 UTC) #10
mvstanton
Sorry to miss it for a while! LGTM.
4 years, 3 months ago (2016-09-23 15:52:59 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367693002/40001
4 years, 3 months ago (2016-09-23 16:09:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2367693002/40001
4 years, 2 months ago (2016-09-24 14:56:14 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-09-24 15:42:14 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-24 15:42:38 UTC) #22
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/43a09146bb92e216fb1674ff0ecea8581df91bd5
Cr-Commit-Position: refs/heads/master@{#39707}

Powered by Google App Engine
This is Rietveld 408576698