Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(227)

Issue 23629051: ARM EH: Extend DWARF_FRAME_REGISTERS count to 48 and map reg# 256 -> 16. (Closed)

Created:
7 years, 3 months ago by jvoung (off chromium)
Modified:
7 years, 3 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-gcc.git@pnacl
Visibility:
Public.

Description

ARM EH: Extend DWARF_FRAME_REGISTERS count to 48 and map reg# 256 -> 16. This avoids indexing out of bounds without using too much memory. This won't work with general dwarf info, but LLVM happens to only generate reg #256->287 for now, so the mapping may be okay. BUG=http://code.google.com/p/nativeclient/issues/detail?id=3689 TEST=./scons bitcode=1 platform=arm \ run_eh_floating_point_opt_frame_test \ run_eh_floating_point_opt_noframe_test \ run_eh_floating_point_noopt_frame_test \ run_eh_floating_point_noopt_noframe_test R=dschuff@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-gcc.git;a=commit;h=2933722

Patch Set 1 #

Patch Set 2 : typos #

Unified diffs Side-by-side diffs Delta from patch set Stats (+39 lines, -7 lines) Patch
M gcc/unwind-dw2.c View 1 chunk +25 lines, -0 lines 0 comments Download
M gcc/unwind-pnacl.h View 1 3 chunks +14 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
jvoung (off chromium)
7 years, 3 months ago (2013-09-18 00:08:02 UTC) #1
Derek Schuff
On 2013/09/18 00:08:02, jvoung (cr) wrote: this lgtm (unless roland has some objection... well, other ...
7 years, 3 months ago (2013-09-18 15:45:28 UTC) #2
jvoung (off chromium)
On 2013/09/18 15:45:28, Derek Schuff wrote: > On 2013/09/18 00:08:02, jvoung (cr) wrote: > > ...
7 years, 3 months ago (2013-09-18 18:46:49 UTC) #3
Derek Schuff
On 2013/09/18 18:46:49, jvoung (cr) wrote: > On 2013/09/18 15:45:28, Derek Schuff wrote: > > ...
7 years, 3 months ago (2013-09-18 19:16:34 UTC) #4
jvoung (off chromium)
7 years, 3 months ago (2013-09-18 19:55:01 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r2933722 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698