Add framework for sending feedback for Blimp.

Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
Committed: https://crrev.com/d98c5c13457fae21894b7413b7407eb0e74d76e1
Cr-Commit-Position: refs/heads/master@{#421136}

[nyquist, 2016-09-23 01:07:22]

Description was changed from

==========
Add framework for sending feedback for blimp.

Before this CL, there was never any information about blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether blimp is supported or not, and it is not there unless blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead.

BUG=637988
==========

to

==========
Add framework for sending feedback for blimp.

Before this CL, there was never any information about blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether blimp is supported or not, and it is not there unless blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

[nyquist, 2016-09-23 01:21:19]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[nyquist, 2016-09-23 01:21:31]

nyquist@chromium.org changed reviewers:
+ dtrainor@chromium.org

[nyquist, 2016-09-23 01:21:31]

dtrainor: PTAL

[commit-bot: I haz the power, 2016-09-23 01:21:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:10:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:10:30]

Dry run: This issue passed the CQ dry run.

[nyquist, 2016-09-23 21:03:28]

The CQ bit was checked by nyquist@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 21:04:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[nyquist, 2016-09-23 23:02:00]

dtrainor: It might be helpful to look at
https://codereview.chromium.org/2371503002 which is building on this CL and adds
the visibility things.

[nyquist, 2016-09-24 22:03:41]

Description was changed from

==========
Add framework for sending feedback for blimp.

Before this CL, there was never any information about blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether blimp is supported or not, and it is not there unless blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

to

==========
Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

[David Trainor- moved to gerrit, 2016-09-27 03:39:23]

lgtm % nits

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
(right):

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java:104:
return blimpFeedbackData.toFeedbackMap();
I almost wish it could be:

return
nativeCreateBlimpFeedbackDataJava(mNativeBlimpClientContextImplAndroid).asMap();

But I'm fine with either :)

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/feedb...
File
blimp/client/core/feedback/android/java/src/org/chromium/blimp/core/feedback/BlimpFeedbackData.java
(right):

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/feedb...
blimp/client/core/feedback/android/java/src/org/chromium/blimp/core/feedback/BlimpFeedbackData.java:24:
if (keys == null || values == null || keys.length != values.length) {
Should this be in the constructor?  That way if we ever have another create
method we can always guarantee the data is validated?

[nyquist, 2016-09-27 06:20:45]

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/andro...
File
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java
(right):

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/andro...
blimp/client/core/android/java/src/org/chromium/blimp/core/BlimpClientContextImpl.java:104:
return blimpFeedbackData.toFeedbackMap();
On 2016/09/27 03:39:23, David Trainor wrote:
> I almost wish it could be:
> 
> return
>
nativeCreateBlimpFeedbackDataJava(mNativeBlimpClientContextImplAndroid).asMap();
> 
> But I'm fine with either :)

Well, now it is :-)

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/feedb...
File
blimp/client/core/feedback/android/java/src/org/chromium/blimp/core/feedback/BlimpFeedbackData.java
(right):

https://codereview.chromium.org/2362693003/diff/60001/blimp/client/core/feedb...
blimp/client/core/feedback/android/java/src/org/chromium/blimp/core/feedback/BlimpFeedbackData.java:24:
if (keys == null || values == null || keys.length != values.length) {
On 2016/09/27 03:39:23, David Trainor wrote:
> Should this be in the constructor?  That way if we ever have another create
> method we can always guarantee the data is validated?

Done. Yeah, I wasn't sure about this myself. Given this was private and only
@CalledByNative, I figured we could do it then. Both ways feel kind of right in
their own respect though, so moving it to the constructor for now.

[nyquist, 2016-09-27 06:20:56]

The CQ bit was checked by nyquist@chromium.org

[nyquist, 2016-09-27 06:20:57]

The patchset sent to the CQ was uploaded after l-g-t-m from
dtrainor@chromium.org
Link to the patchset: https://codereview.chromium.org/2362693003/#ps100001
(title: "Rebased for good measure")

[commit-bot: I haz the power, 2016-09-27 06:21:06]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 07:17:56]

Description was changed from

==========
Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

to

==========
Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

[commit-bot: I haz the power, 2016-09-27 07:17:58]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-27 07:21:24]

Description was changed from

==========
Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988
==========

to

==========
Add framework for sending feedback for Blimp.

Before this CL, there was never any information about Blimp included in
the feedback data provided to HelpAndFeedback. This CL adds a framework
for adding such feedback data. The only field that is currently set
is whether Blimp is supported or not, and it is not there unless Blimp
is supported.

The feedback collection is cross-platform, but it is currently only
used for Android, and initiated from Java in the FeedbackCollector.

The data needs to end up as a Bundle with only <String, String> data,
so the cross platform code also uses a map of strings as keys and
values.

The JNI-bridge code takes the source map and converts it into a Java
object holding a Map<String, String> which is provided to the
FeedbackCollector. There is no additional business logic in Java.
Since there is no way to pass for example std::unordered_map from C++
to Java, the keys and values are passed as simple Java-arrays
during construction of the Java object instead. After the Java
object has been constructed, it lives on its own and does not require
access to functions in C++.

BUG=637988

Committed: https://crrev.com/d98c5c13457fae21894b7413b7407eb0e74d76e1
Cr-Commit-Position: refs/heads/master@{#421136}
==========

[commit-bot: I haz the power, 2016-09-27 07:21:25]

Patchset 6 (id:??) landed as
https://crrev.com/d98c5c13457fae21894b7413b7407eb0e74d76e1
Cr-Commit-Position: refs/heads/master@{#421136}