Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5114)

Unified Diff: blimp/client/core/BUILD.gn

Issue 2362693003: Add framework for sending feedback for Blimp. (Closed)
Patch Set: Rebased for good measure Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/core/BUILD.gn
diff --git a/blimp/client/core/BUILD.gn b/blimp/client/core/BUILD.gn
index 5888f07e43a597fb3df259f8a2824d9802ad426e..121de4fdccbd4ac333f10de3ec245c1fdeb931f4 100644
--- a/blimp/client/core/BUILD.gn
+++ b/blimp/client/core/BUILD.gn
@@ -37,6 +37,7 @@ group("core") {
":switches",
"//blimp/client/core/compositor",
"//blimp/client/core/contents",
+ "//blimp/client/core/feedback",
"//blimp/client/core/geolocation",
"//blimp/client/core/render_widget",
"//blimp/client/core/session",
@@ -80,6 +81,7 @@ source_set("unit_tests") {
":context",
"//blimp/client/core/compositor:unit_tests",
"//blimp/client/core/contents:unit_tests",
+ "//blimp/client/core/feedback:unit_tests",
"//blimp/client/core/geolocation:unit_tests",
"//blimp/client/core/render_widget:unit_tests",
"//blimp/client/core/session:unit_tests",
@@ -108,6 +110,7 @@ source_set("context") {
deps = [
":switches",
+ "//blimp/client/core/feedback",
"//blimp/client/core/geolocation",
"//blimp/client/core/settings",
]
@@ -168,6 +171,7 @@ if (is_android) {
":context_java",
":switches_java",
"//blimp/client/core/contents:contents_java",
+ "//blimp/client/core/feedback:feedback_java",
"//blimp/client/core/settings:settings_java",
"//device/geolocation:geolocation_java",
]
@@ -195,6 +199,7 @@ if (is_android) {
":switches_java",
"//base:base_java",
"//blimp/client/core/contents:contents_java",
+ "//blimp/client/core/feedback:feedback_java",
"//blimp/client/core/settings:settings_java",
"//blimp/client/public:public_headers_java",
"//ui/android:ui_java",

Powered by Google App Engine
This is Rietveld 408576698