Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2362633002: [MD Downloads/Settings] Fix card style nits. (Closed)

Created:
4 years, 3 months ago by calamity
Modified:
4 years, 2 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, chrome-apps-syd-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[MD Downloads/Settings] Fix card style nits. BUG=639893 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/59aba0008e071151057843543ff57fa6f25e4cf9 Cr-Commit-Position: refs/heads/master@{#421098}

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -4 lines) Patch
M chrome/browser/resources/md_downloads/item.css View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/settings/settings_page/settings_section.html View 1 chunk +1 line, -0 lines 0 comments Download

Depends on Patchset:

Issue 2339523004 Patch 140001

Dependent Patchsets:

Issue 2374473003 Patch 20001

Messages

Total messages: 22 (12 generated)
calamity
4 years, 3 months ago (2016-09-22 07:31:13 UTC) #3
Dan Beam
lgtm thanks!
4 years, 3 months ago (2016-09-22 18:14:40 UTC) #7
Dan Beam
also, fwiw: bettes@ wanted a lighter shadow than the polymer default (for some reason) which ...
4 years, 3 months ago (2016-09-22 18:15:13 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362633002/40001
4 years, 2 months ago (2016-09-26 06:59:30 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/147868)
4 years, 2 months ago (2016-09-26 09:32:18 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362633002/40001
4 years, 2 months ago (2016-09-26 17:29:42 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/148278)
4 years, 2 months ago (2016-09-26 20:35:43 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2362633002/40001
4 years, 2 months ago (2016-09-27 01:02:13 UTC) #18
commit-bot: I haz the power
Committed patchset #1 (id:40001)
4 years, 2 months ago (2016-09-27 04:13:41 UTC) #20
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 04:16:47 UTC) #22
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/59aba0008e071151057843543ff57fa6f25e4cf9
Cr-Commit-Position: refs/heads/master@{#421098}

Powered by Google App Engine
This is Rietveld 408576698