Remove old (dead) app list code.

Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org

Committed: https://crrev.com/7bfaddb74bc2e0d49c7c47eff289bf71389c4446
Cr-Commit-Position: refs/heads/master@{#420518}

[Matt Giuca, 2016-09-16 05:13:54]

Patchset #2 (id:20001) has been deleted

[Matt Giuca, 2016-09-19 03:50:21]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-19 03:50:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Matt Giuca, 2016-09-19 03:50:41]

mgiuca@chromium.org changed reviewers:
+ calamity@chromium.org

[commit-bot: I haz the power, 2016-09-19 04:14:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-19 04:14:52]

Dry run: This issue passed the CQ dry run.

[Matt Giuca, 2016-09-21 01:01:06]

Hey, friendly ping.

[Matt Giuca, 2016-09-21 03:12:46]

The CQ bit was checked by mgiuca@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 03:13:18]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-21 03:40:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-21 03:40:53]

Dry run: This issue passed the CQ dry run.

[calamity, 2016-09-21 07:54:10]

lgtm with non-optional nits but I still trust you to fix them and then land (or
lgtmwnonbistytftatl for short)

https://codereview.chromium.org/2339523004/diff/140001/ash/app_list/app_list_...
File ash/app_list/app_list_presenter_delegate.cc (right):

https://codereview.chromium.org/2339523004/diff/140001/ash/app_list/app_list_...
ash/app_list/app_list_presenter_delegate.cc:130: // The experimental app list is
centered over the display of the app list
nit: Gotcha.

https://codereview.chromium.org/2339523004/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(left):

https://codereview.chromium.org/2339523004/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:131:
// the app launcher is open to the start page. On the non-experimental launcher,
nit: Remove last sentence here.

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
ui/app_list/views/contents_view.h:181: // Special sub views of the ContentsView.
All owned by the views hierarchy.
nit: Nothing special here. I think that was a remnant of the extensible
CustomLauncherPage days.

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
ui/app_list/views/contents_view.h:184: 
nit: Remove this blank line.

[Matt Giuca, 2016-09-22 06:49:44]

https://codereview.chromium.org/2339523004/diff/140001/ash/app_list/app_list_...
File ash/app_list/app_list_presenter_delegate.cc (right):

https://codereview.chromium.org/2339523004/diff/140001/ash/app_list/app_list_...
ash/app_list/app_list_presenter_delegate.cc:130: // The experimental app list is
centered over the display of the app list
On 2016/09/21 07:54:10, calamity wrote:
> nit: Gotcha.

Ah, I didn't grep ash.

https://codereview.chromium.org/2339523004/diff/140001/chrome/browser/ui/ash/...
File
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
(left):

https://codereview.chromium.org/2339523004/diff/140001/chrome/browser/ui/ash/...
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc:131:
// the app launcher is open to the start page. On the non-experimental launcher,
On 2016/09/21 07:54:10, calamity wrote:
> nit: Remove last sentence here.

Done.

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
File ui/app_list/views/contents_view.h (right):

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
ui/app_list/views/contents_view.h:181: // Special sub views of the ContentsView.
All owned by the views hierarchy.
On 2016/09/21 07:54:10, calamity wrote:
> nit: Nothing special here. I think that was a remnant of the extensible
> CustomLauncherPage days.

Done.

https://codereview.chromium.org/2339523004/diff/140001/ui/app_list/views/cont...
ui/app_list/views/contents_view.h:184: 
On 2016/09/21 07:54:10, calamity wrote:
> nit: Remove this blank line.

Done.

[Matt Giuca, 2016-09-22 06:52:09]

Description was changed from

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
==========

to

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org,skuhne@chromium.org
==========

[Matt Giuca, 2016-09-22 06:53:31]

mgiuca@chromium.org changed reviewers:
+ jamescook@chromium.org, plundblad@chromium.org, skuhne@chromium.org

[Matt Giuca, 2016-09-22 06:53:31]

Adding OWNERS reviewers.

jamescook: Please review ash changes.
plundblad: Please review
chrome/browser/chromeos/accessibility/spoken_feedback_browsertest.cc [TBR for
minor mechanical change].
skuhne: Please review
chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
[TBR for minor mechanical change].

[James Cook, 2016-09-22 15:02:45]

ash LGTM. Nice cleanup.

https://codereview.chromium.org/2339523004/diff/160001/ash/app_list/app_list_...
File ash/app_list/app_list_presenter_delegate.cc (right):

https://codereview.chromium.org/2339523004/diff/160001/ash/app_list/app_list_...
ash/app_list/app_list_presenter_delegate.cc:66:
switches::kAshEnableFullscreenAppList);
Question for you (or skuhne): Is fullscreen app list in maximize mode going to
become the default? If not, can this switch be removed also (in a later CL)?

[Mr4D (OOO till 08-26), 2016-09-22 18:17:48]

chrome/browser/ui/ash/launcher/chrome_launcher_controller_impl_browsertest.cc
lgtm.

Nice!! Remove the dead code!

[Matt Giuca, 2016-09-23 00:11:54]

https://codereview.chromium.org/2339523004/diff/160001/ash/app_list/app_list_...
File ash/app_list/app_list_presenter_delegate.cc (right):

https://codereview.chromium.org/2339523004/diff/160001/ash/app_list/app_list_...
ash/app_list/app_list_presenter_delegate.cc:66:
switches::kAshEnableFullscreenAppList);
On 2016/09/22 15:02:45, James Cook wrote:
> Question for you (or skuhne): Is fullscreen app list in maximize mode going to
> become the default? If not, can this switch be removed also (in a later CL)?

I don't have any state on this; I think this has been around since forever and I
don't think it's used any more (is it from Athena?). I don't think there are
plans to make it the default.

[Matt Giuca, 2016-09-23 00:12:16]

Description was changed from

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org,skuhne@chromium.org
==========

to

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org
==========

[Matt Giuca, 2016-09-23 00:12:27]

The CQ bit was checked by mgiuca@chromium.org

[Matt Giuca, 2016-09-23 00:12:27]

The patchset sent to the CQ was uploaded after l-g-t-m from
calamity@chromium.org
Link to the patchset: https://codereview.chromium.org/2339523004/#ps160001
(title: "Address nonbistytftatl review.")

[commit-bot: I haz the power, 2016-09-23 00:12:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:00:55]

Description was changed from

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org
==========

to

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org
==========

[commit-bot: I haz the power, 2016-09-23 01:00:57]

Committed patchset #8 (id:160001)

[commit-bot: I haz the power, 2016-09-23 01:03:18]

Description was changed from

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org
==========

to

==========
Remove old (dead) app list code.

This deletes the IsExperimentalAppListEnabled and related functions
(which were vestigial) and cleans up all call sites to always do the
"experimental" behaviour. Also renames some variables and cleans up
comments to reflect that the "experimental" behaviour is now the norm.

BUG=531059
TBR=plundblad@chromium.org

Committed: https://crrev.com/7bfaddb74bc2e0d49c7c47eff289bf71389c4446
Cr-Commit-Position: refs/heads/master@{#420518}
==========

[commit-bot: I haz the power, 2016-09-23 01:03:20]

Patchset 8 (id:??) landed as
https://crrev.com/7bfaddb74bc2e0d49c7c47eff289bf71389c4446
Cr-Commit-Position: refs/heads/master@{#420518}