Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 2374473003: MD Downloads: remove most deprecated CSS imports (Closed)

Created:
4 years, 2 months ago by Dan Beam
Modified:
4 years, 2 months ago
Reviewers:
tsergeant
CC:
chromium-reviews, asanka, michaelpg+watch-md-ui_chromium.org, arv+watch_chromium.org, dbeam+watch-downloads_chromium.org, calamity
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

MD Downloads: remove most deprecated CSS imports This CL merges component.css files into respective component.html files. This reduces Download's use of the deprecated <link type="css"> syntax and more closely resembles other MD pages. While I was at it: shared_styles.css had basically outlived its usefulness, so I put some --vars in the top-level page and duplicated a couple of small [hidden] { display: none !important; } rules across components (because it seems better than making a shared CSS module). Depends on both of these lovely changes: https://codereview.chromium.org/2362633002/ https://codereview.chromium.org/2370653002/ R=tsergeant@chromium.org BUG=650504 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Committed: https://crrev.com/36d04319120c222cc12de7a788b547f4773da845 Cr-Commit-Position: refs/heads/master@{#421258}

Patch Set 1 : 80 col wrap #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+529 lines, -555 lines) Patch
M chrome/browser/browser_resources.grd View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/resources/md_downloads/downloads.html View 1 chunk +5 lines, -0 lines 1 comment Download
D chrome/browser/resources/md_downloads/item.css View 1 chunk +0 lines, -211 lines 0 comments Download
M chrome/browser/resources/md_downloads/item.html View 2 chunks +222 lines, -2 lines 1 comment Download
D chrome/browser/resources/md_downloads/manager.css View 1 chunk +0 lines, -74 lines 0 comments Download
M chrome/browser/resources/md_downloads/manager.html View 2 chunks +80 lines, -2 lines 0 comments Download
D chrome/browser/resources/md_downloads/shared_style.css View 1 chunk +0 lines, -17 lines 0 comments Download
D chrome/browser/resources/md_downloads/toolbar.css View 1 chunk +0 lines, -70 lines 0 comments Download
M chrome/browser/resources/md_downloads/toolbar.html View 2 chunks +72 lines, -2 lines 0 comments Download
M chrome/browser/resources/md_downloads/vulcanized.html View 16 chunks +150 lines, -173 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 13 (8 generated)
Dan Beam
https://codereview.chromium.org/2374473003/diff/20001/chrome/browser/resources/md_downloads/downloads.html File chrome/browser/resources/md_downloads/downloads.html (right): https://codereview.chromium.org/2374473003/diff/20001/chrome/browser/resources/md_downloads/downloads.html#newcode25 chrome/browser/resources/md_downloads/downloads.html:25: --downloads-card-width: 622px; i also renamed this from "downloads-item-width" to ...
4 years, 2 months ago (2016-09-27 01:25:23 UTC) #6
tsergeant
lgtm
4 years, 2 months ago (2016-09-27 03:03:58 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2374473003/20001
4 years, 2 months ago (2016-09-27 16:45:22 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:20001)
4 years, 2 months ago (2016-09-27 17:53:29 UTC) #11
commit-bot: I haz the power
4 years, 2 months ago (2016-09-27 17:55:06 UTC) #13
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/36d04319120c222cc12de7a788b547f4773da845
Cr-Commit-Position: refs/heads/master@{#421258}

Powered by Google App Engine
This is Rietveld 408576698