Cleanup Mutex and related classes.

Cleanup Mutex and related classes.

Drop the previous Mutex and ScopedLock classes from platform files.

Add new Mutex, RecursiveMutex and LockGuard classes, which are
designed after their C++11 counterparts, so that at some point
we can simply drop our custom code and switch to the C++11
classes. We distinguish regular and recursive mutexes, as the
latter don't work well with condition variables, which will be
introduced by a followup CL.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16416

[Benedikt Meurer, 2013-08-28 07:18:34]

Hey Michi,
This is mostly mechnical refactoring.
PTAL

(had to create a new CL because of the damn broken git cl "base files missing"
crap $*%&!$#!)

[Michael Starzinger, 2013-08-28 10:42:49]

Is there a particular reason for adding the "synchronization" subdirectory?

[Benedikt Meurer, 2013-08-28 10:44:45]

On 2013/08/28 10:42:49, Michael Starzinger wrote:
> Is there a particular reason for adding the "synchronization" subdirectory?

The idea is to put all synchronization stuff there, i.e. mutexes, condition
variables, semaphores, etc.

[Michael Starzinger, 2013-08-28 12:20:53]

As discussed offline: Instead of creating a new "synchronization" directory,
let's use a more general "platform" directory for OS-dependent artifacts.

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode371
src/isolate.cc:371: }
This introduces a potential race as we might allocate two per isolate data
structures and the thread_data_table will be accessed concurrently.

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1753
src/isolate.cc:1753: // Must be initialized early to allow
v8::SetResourceConstraints calls.
Comment applied to the line being removed, let's also drop the comment.

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1755
src/isolate.cc:1755: // Must be initialized early to allow v8::Debug calls.
Comment applied to the line being removed, let's also drop the comment.

[Benedikt Meurer, 2013-08-28 12:43:23]

PTAL

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc
File src/isolate.cc (right):

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode371
src/isolate.cc:371: }
On 2013/08/28 12:20:54, Michael Starzinger wrote:
> This introduces a potential race as we might allocate two per isolate data
> structures and the thread_data_table will be accessed concurrently.

Done.

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1753
src/isolate.cc:1753: // Must be initialized early to allow
v8::SetResourceConstraints calls.
On 2013/08/28 12:20:54, Michael Starzinger wrote:
> Comment applied to the line being removed, let's also drop the comment.

Done.

https://codereview.chromium.org/23625003/diff/1/src/isolate.cc#newcode1755
src/isolate.cc:1755: // Must be initialized early to allow v8::Debug calls.
On 2013/08/28 12:20:54, Michael Starzinger wrote:
> Comment applied to the line being removed, let's also drop the comment.

Done.

[Michael Starzinger, 2013-08-28 13:03:40]

LGTM.

[Benedikt Meurer, 2013-08-29 10:00:11]

Committed patchset #10 manually as r16416 (presubmit successful).