third_party/WebKit/Source/core/html/HTMLElement.cpp - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLElement.cpp

diff --git a/third_party/WebKit/Source/core/html/HTMLElement.cpp b/third_party/WebKit/Source/core/html/HTMLElement.cpp

index 7e81ee34f4724399f6a382b5915d5024fc6f0173..bda696a16548068de23c62e89064ae39289b36af 100644

--- a/third_party/WebKit/Source/core/html/HTMLElement.cpp

+++ b/third_party/WebKit/Source/core/html/HTMLElement.cpp

@@ -688,7 +688,7 @@ String HTMLElement::title() const {

return fastGetAttribute(titleAttr);

}

-short HTMLElement::tabIndex() const {

+int HTMLElement::tabIndex() const {

if (supportsFocus())

return Element::tabIndex();

return -1;