third_party/WebKit/Source/core/html/HTMLFieldSetElement.h - Issue 2362223002: Stop clamping tabIndex to short range

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

Issue 2362223002: Stop clamping tabIndex to short range (Closed)

Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

diff --git a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

index 1b04e07894cfa44555fcb5be81aa71c5bb0a3344..b47d303ec11c531600d748a757fa214a5fe5f824 100644

--- a/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

+++ b/third_party/WebKit/Source/core/html/HTMLFieldSetElement.h

@@ -54,7 +54,7 @@ class CORE_EXPORT HTMLFieldSetElement final : public HTMLFormControlElement {

LayoutObject* createLayoutObject(const ComputedStyle&) override;

const AtomicString& formControlType() const override;

bool recalcWillValidate() const override { return false; }

- short tabIndex() const final;

+ int tabIndex() const final;

bool matchesValidityPseudoClasses() const final;

bool isValidElement() final;

void childrenChanged(const ChildrenChange&) override;