Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(102)

Side by Side Diff: third_party/WebKit/Source/core/html/HTMLElement.cpp

Issue 2362223002: Stop clamping tabIndex to short range (Closed)
Patch Set: Fix tabindex-clamp.html Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved. 4 * Copyright (C) 2004-2008, 2013, 2014 Apple Inc. All rights reserved.
5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved. 5 * Copyright (C) 2009 Torch Mobile Inc. All rights reserved.
6 * (http://www.torchmobile.com/) 6 * (http://www.torchmobile.com/)
7 * Copyright (C) 2011 Motorola Mobility. All rights reserved. 7 * Copyright (C) 2011 Motorola Mobility. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 670 matching lines...) Expand 10 before | Expand all | Expand 10 after
681 681
682 void HTMLElement::accessKeyAction(bool sendMouseEvents) { 682 void HTMLElement::accessKeyAction(bool sendMouseEvents) {
683 dispatchSimulatedClick( 683 dispatchSimulatedClick(
684 0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEvents); 684 0, sendMouseEvents ? SendMouseUpDownEvents : SendNoEvents);
685 } 685 }
686 686
687 String HTMLElement::title() const { 687 String HTMLElement::title() const {
688 return fastGetAttribute(titleAttr); 688 return fastGetAttribute(titleAttr);
689 } 689 }
690 690
691 short HTMLElement::tabIndex() const { 691 int HTMLElement::tabIndex() const {
692 if (supportsFocus()) 692 if (supportsFocus())
693 return Element::tabIndex(); 693 return Element::tabIndex();
694 return -1; 694 return -1;
695 } 695 }
696 696
697 TranslateAttributeMode HTMLElement::translateAttributeMode() const { 697 TranslateAttributeMode HTMLElement::translateAttributeMode() const {
698 const AtomicString& value = getAttribute(translateAttr); 698 const AtomicString& value = getAttribute(translateAttr);
699 699
700 if (value == nullAtom) 700 if (value == nullAtom)
701 return TranslateAttributeInherit; 701 return TranslateAttributeInherit;
(...skipping 501 matching lines...) Expand 10 before | Expand all | Expand 10 after
1203 1203
1204 #ifndef NDEBUG 1204 #ifndef NDEBUG
1205 1205
1206 // For use in the debugger 1206 // For use in the debugger
1207 void dumpInnerHTML(blink::HTMLElement*); 1207 void dumpInnerHTML(blink::HTMLElement*);
1208 1208
1209 void dumpInnerHTML(blink::HTMLElement* element) { 1209 void dumpInnerHTML(blink::HTMLElement* element) {
1210 printf("%s\n", element->innerHTML().ascii().data()); 1210 printf("%s\n", element->innerHTML().ascii().data());
1211 } 1211 }
1212 #endif 1212 #endif
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLElement.h ('k') | third_party/WebKit/Source/core/html/HTMLFieldSetElement.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698