Issue 23622023: Revert 222204 "Revert 222150 "Telemetry: smoothness measurement ..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23622023: Revert 222204 "Revert 222150 "Telemetry: smoothness measurement ..." (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 3 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 222204 "Revert 222150 "Telemetry: smoothness measurement ..." Re-apply 222150. Revert didn't fix testGotQueryParams. > Revert 222150 "Telemetry: smoothness measurement throws MissingT..." > > Breaks testGotQueryParams on Mac 10.6 and 10.7. > > > Telemetry: smoothness measurement throws MissingTimelineMarker. > > > > Rather than throwing a generic LookupError exception when the timeline marker > > cannot be found in the trace, throw a MissingTimelineMarker which is a subclass > > of page_measurement.MeasurementFailure. These exceptios get caught by the page > > runner. > > > > Stop catching LookupError exeptions in _RunPage. > > > > BUG=238864 > > > > Review URL: https://chromiumcodereview.appspot.com/23766009 > > TBR=dominikg@chromium.org > > Review URL: https://codereview.chromium.org/23693005 TBR=vitalybuka@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222219

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -2 lines)			Patch
	M	trunk/src/tools/perf/measurements/smoothness.py	View		2 chunks	+9 lines, -1 line	0 comments	Download
	M	trunk/src/tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

7 years, 3 months ago (2013-09-10 08:46:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r222219.

Expand Messages | Collapse Messages