Issue 23693005: Revert 222150 "Telemetry: smoothness measurement throws MissingT..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 23693005: Revert 222150 "Telemetry: smoothness measurement throws MissingT..." (Closed)

Created:
7 years, 3 months ago by Vitaly Buka (NO REVIEWS)

Modified:
7 years, 3 months ago

Reviewers:
Dominik Grewe

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 222150 "Telemetry: smoothness measurement throws MissingT..." Breaks testGotQueryParams on Mac 10.6 and 10.7. > Telemetry: smoothness measurement throws MissingTimelineMarker. > > Rather than throwing a generic LookupError exception when the timeline marker > cannot be found in the trace, throw a MissingTimelineMarker which is a subclass > of page_measurement.MeasurementFailure. These exceptios get caught by the page > runner. > > Stop catching LookupError exeptions in _RunPage. > > BUG=238864 > > Review URL: https://chromiumcodereview.appspot.com/23766009 TBR=dominikg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222204

Patch Set 1 #

Created: 7 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+2 lines, -10 lines)			Patch
	M	trunk/src/tools/perf/measurements/smoothness.py	View		2 chunks	+1 line, -9 lines	0 comments	Download
	M	trunk/src/tools/telemetry/telemetry/page/page_runner.py	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Vitaly Buka (NO REVIEWS)

Committed patchset #1 manually as r222204.

7 years, 3 months ago (2013-09-10 07:58:34 UTC) #2

Dominik Grewe

Can you please let me know how what the problem was so I can fix ...

7 years, 3 months ago (2013-09-10 08:41:47 UTC) #3

Vitaly Buka (NO REVIEWS)

7 years, 3 months ago (2013-09-10 08:48:26 UTC) #4

Message was sent while issue was closed.

On 2013/09/10 08:41:47, Dominik Grewe wrote:
> Can you please let me know how what the problem was so I can fix my original
CL?
> Do you have any logs from the failed test? I'd like to understand what went
> wrong.

Didn't help, just re-applyed back. Suspecting 222145
http://build.chromium.org/p/chromium.mac/builders/Mac10.6%20Tests%20%283%29

Expand Messages | Collapse Messages