Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Unified Diff: trunk/src/tools/perf/measurements/smoothness.py

Issue 23622023: Revert 222204 "Revert 222150 "Telemetry: smoothness measurement ..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | trunk/src/tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: trunk/src/tools/perf/measurements/smoothness.py
===================================================================
--- trunk/src/tools/perf/measurements/smoothness.py (revision 222217)
+++ trunk/src/tools/perf/measurements/smoothness.py (working copy)
@@ -6,15 +6,23 @@
from metrics.gpu_rendering_stats import GpuRenderingStats
from telemetry.page import page_measurement
+
class DidNotScrollException(page_measurement.MeasurementFailure):
def __init__(self):
super(DidNotScrollException, self).__init__('Page did not scroll')
+
class MissingDisplayFrameRate(page_measurement.MeasurementFailure):
def __init__(self, name):
super(MissingDisplayFrameRate, self).__init__(
'Missing display frame rate metrics: ' + name)
+
+class MissingTimelineMarker(page_measurement.MeasurementFailure):
+ def __init__(self):
+ super(MissingTimelineMarker, self).__init__('Timeline marker not found')
+
+
class Smoothness(page_measurement.PageMeasurement):
def __init__(self):
super(Smoothness, self).__init__('smoothness')
@@ -59,7 +67,7 @@
smoothness.TIMELINE_MARKER)
if s.parent_slice == None]
if len(events) != 1:
- raise LookupError, 'timeline marker not found'
+ raise MissingTimelineMarker()
return events[0]
def MeasurePage(self, page, tab, results):
« no previous file with comments | « no previous file | trunk/src/tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698