Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1133)

Unified Diff: chrome/browser/android/offline_pages/offline_page_tab_helper.h

Issue 2362033002: Showing previews UI for Offline Previews (Closed)
Patch Set: Simplified Offline Pages Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/offline_pages/offline_page_tab_helper.h
diff --git a/chrome/browser/android/offline_pages/offline_page_tab_helper.h b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
index 8ded15dff9f73a0f2da25095d9520ed0315bb29d..8c0299a8fc5d3530fa445eeabaea614f5d95d5f1 100644
--- a/chrome/browser/android/offline_pages/offline_page_tab_helper.h
+++ b/chrome/browser/android/offline_pages/offline_page_tab_helper.h
@@ -35,21 +35,21 @@ class OfflinePageTabHelper :
const OfflinePageItem* offline_page() {
return offline_info_.offline_page.get();
}
const OfflinePageHeader& offline_header() const {
return offline_info_.offline_header;
}
// Whether the page is an offline preview.
- bool is_offline_preview() const { return offline_info_.is_offline_preview; }
+ bool IsOfflinePreview() const;
jianli 2016/10/25 22:14:16 nit: rename to IsShowingOfflinePreview in order to
RyanSturm 2016/10/25 23:08:26 Done.
// Returns provisional offline page since actual navigation does not happen
// during unit tests.
const OfflinePageItem* GetOfflinePageForTest() const;
private:
friend class content::WebContentsUserData<OfflinePageTabHelper>;
// Contains the info about the offline page being loaded.
struct LoadedOfflinePageInfo {

Powered by Google App Engine
This is Rietveld 408576698