Showing previews UI for Offline Previews

chrome/browser/android/offline_pages/offline_page_tab_helper.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_
 
 #include "base/macros.h"
 #include "base/memory/weak_ptr.h"
 #include "base/time/time.h"
@@ skipping 24 matching lines @@
 
   const OfflinePageItem* offline_page() {
     return offline_info_.offline_page.get();
   }
 
   const OfflinePageHeader& offline_header() const {
     return offline_info_.offline_header;
   }
 
   // Whether the page is an offline preview.
-  bool is_offline_preview() const { return offline_info_.is_offline_preview; }
+  bool IsOfflinePreview() const;

[jianli, 2016/10/25 22:14:16]

nit: rename to IsShowingOfflinePreview in order to be consistent with other
places

Also, please change is_offline_preview to is_showing_offline_preview in
LoadedOfflinePageInfo.

[RyanSturm, 2016/10/25 23:08:26]

Done.

 
   // Returns provisional offline page since actual navigation does not happen
   // during unit tests.
   const OfflinePageItem* GetOfflinePageForTest() const;
 
  private:
   friend class content::WebContentsUserData<OfflinePageTabHelper>;
 
   // Contains the info about the offline page being loaded.
   struct LoadedOfflinePageInfo {
@@ skipping 37 matching lines @@
   bool reloading_url_on_net_error_ = false;
 
   base::WeakPtrFactory<OfflinePageTabHelper> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(OfflinePageTabHelper);
 };
 
 }  // namespace offline_pages
 
 #endif  // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_TAB_HELPER_H_