Showing previews UI for Offline Previews

chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java

Index: chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
index 98862b1eaa74e6bb4f33e65c497e2b62f7ad5cd0..d4ea50e79bd24fa72c839b4eb472a7df88a5ce62 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java
@@ -2871,20 +2871,27 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
     }
 
     /**
      * @return True if the offline page is opened.
      */
     public boolean isOfflinePage() {
         return isFrozen() ? false : nativeIsOfflinePage(mNativeTabAndroid);
     }
 
     /**
+     * @return True if the offline page is opened.
+     */
+    public boolean isShowingOfflinePreview() {

[jianli, 2016/10/25 22:14:16]

We should try to avoid adding more offline related codes into Tab. Instead, you
could put them in OfflinePageUtils (see how I did it for
getOfflinePageHeaderForReload).

FYI, this is per feedback from tedchoc in my previous review. We're going to
move offline handling logic from Tab to OfflinePageUtils.

[RyanSturm, 2016/10/25 23:08:26]

Done.

+        return isFrozen() ? false : nativeIsShowingOfflinePreview(mNativeTabAndroid);
+    }
+
+    /**
      * @return The offline page if tab currently displays it, null otherwise.
      */
     public OfflinePageItem getOfflinePage() {
         return isFrozen() ? null : nativeGetOfflinePage(mNativeTabAndroid);
     }
 
     /**
      * Shows the list of offline pages. This should only be hit when offline pages feature is
      * enabled.
      */
@@ -3243,17 +3250,18 @@ public class Tab implements ViewGroup.OnHierarchyChangeListener,
     private native void nativeSetActiveNavigationEntryTitleForUrl(long nativeTabAndroid, String url,
             String title);
     private native boolean nativePrint(long nativeTabAndroid);
     private native Bitmap nativeGetFavicon(long nativeTabAndroid);
     private native void nativeCreateHistoricalTab(long nativeTabAndroid);
     private native void nativeUpdateTopControlsState(
             long nativeTabAndroid, int constraints, int current, boolean animate);
     private native void nativeLoadOriginalImage(long nativeTabAndroid);
     private native long nativeGetBookmarkId(long nativeTabAndroid, boolean onlyEditable);
     private native boolean nativeIsOfflinePage(long nativeTabAndroid);
+    private native boolean nativeIsShowingOfflinePreview(long nativeTabAndroid);
     private native OfflinePageItem nativeGetOfflinePage(long nativeTabAndroid);
     private native void nativeSetInterceptNavigationDelegate(long nativeTabAndroid,
             InterceptNavigationDelegate delegate);
     private native void nativeAttachToTabContentManager(long nativeTabAndroid,
             TabContentManager tabContentManager);
     private native boolean nativeHasPrerenderedUrl(long nativeTabAndroid, String url);
 }