BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLPlugInElement.h

Index: Source/core/html/HTMLPlugInElement.h
diff --git a/Source/core/html/HTMLPlugInElement.h b/Source/core/html/HTMLPlugInElement.h
index 186314556e8b94f7a261c118a30881c6d33c2e84..dcca5cbcfc7f375bda2d9ad21e6b988801b676b5 100644
--- a/Source/core/html/HTMLPlugInElement.h
+++ b/Source/core/html/HTMLPlugInElement.h
@@ -61,6 +61,12 @@ public:
     void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
     virtual void updateWidget(PluginCreationOption) = 0;
 
+    void createPluginWithoutRenderer(const String& mimeType);
+    // Allows persisted plugins to be registered by their creator. Call this
+    // function with an argument of 0 to clear the persisted plugin.
+    void setPlugin(PassRefPtr<Widget>);
+    PassRefPtr<Widget> plugin();

[eseidel, 2013/11/18 22:26:45]

Normally you don't return PassRefPtr unless the caller is expected to take
ownership (like a create() method).  In this case, you probably just want
Widget* indicating that this object retains ownership and that the Widget*
should last as long as it does.

[wjmaclean, 2013/11/25 17:51:56]

Yes ... I think I changed this in response to a compiler error I saw, and wasn't
thinking very carefully about what I was doing.

Fixed.

+
 protected:
     HTMLPlugInElement(const QualifiedName& tagName, Document&, bool createdByParser, PreferPlugInsForImagesOption);
 
@@ -135,6 +141,10 @@ private:
     bool m_needsWidgetUpdate;
     bool m_shouldPreferPlugInsForImages;
     DisplayState m_displayState;
+
+    // Keep track of any plugins that wish to be persisted.
+    RefPtr<Widget> m_plugin;
+    String m_pluginMimeType;
 };
 
 DEFINE_NODE_TYPE_CASTS(HTMLPlugInElement, isPluginElement());