BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLObjectElement.cpp

Index: Source/core/html/HTMLObjectElement.cpp
diff --git a/Source/core/html/HTMLObjectElement.cpp b/Source/core/html/HTMLObjectElement.cpp
index 72d7db9ac54df0dd75de556a521fdba4dcb4e12a..ff860ea474f9bbc478be74dd8fd9456528b27335 100644
--- a/Source/core/html/HTMLObjectElement.cpp
+++ b/Source/core/html/HTMLObjectElement.cpp
@@ -98,6 +98,8 @@ void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicSt
             m_serviceType = m_serviceType.left(pos);
         if (renderer())
             setNeedsWidgetUpdate(true);

[eseidel, 2013/11/18 22:26:45]

I take it we're trying to avoid synchronously creating the plugin at this
callstack?  Presumably because plugin creation can do all sorts of things and
may cause us to reenter?

[wjmaclean, 2013/11/25 17:51:56]

This needs to be investigated further, but I'm guessing if re-entrancy is
possible, it's due to layout issues. Would that be a problem if we are creating
the plugin without a renderer?

Nonetheless, I've tried the approach of calling setNeedsWidgetUpdate(true) with
or without a renderer and then in HTMLPlugInElement::updateWidgetIfNecessary()
create the plugin without a renderer for supported plugin types. So far so good,
but I'm continuing to test it ...

+        else
+            createPluginWithoutRenderer(m_serviceType);
     } else if (name == dataAttr) {
         m_url = stripLeadingAndTrailingHTMLSpaces(value);
         if (renderer()) {