BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLPlugInElement.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  * Copyright (C) 2004, 2006, 2007, 2008, 2009, 2012 Apple Inc. All rights reserved.
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
  * version 2 of the License, or (at your option) any later version.
  *
@@ skipping 43 matching lines @@
     Widget* pluginWidget() const;
     NPObject* getNPObject();
     bool canProcessDrag() const;
     const String& url() const { return m_url; }
 
     // Public for FrameView::addWidgetToUpdate()
     bool needsWidgetUpdate() const { return m_needsWidgetUpdate; }
     void setNeedsWidgetUpdate(bool needsWidgetUpdate) { m_needsWidgetUpdate = needsWidgetUpdate; }
     virtual void updateWidget(PluginCreationOption) = 0;
 
+    void createPluginWithoutRenderer(const String& mimeType);
+    // Allows persisted plugins to be registered by their creator. Call this
+    // function with an argument of 0 to clear the persisted plugin.
+    void setPlugin(PassRefPtr<Widget>);
+    PassRefPtr<Widget> plugin();

[eseidel, 2013/11/18 22:26:45]

Normally you don't return PassRefPtr unless the caller is expected to take
ownership (like a create() method).  In this case, you probably just want
Widget* indicating that this object retains ownership and that the Widget*
should last as long as it does.

[wjmaclean, 2013/11/25 17:51:56]

Yes ... I think I changed this in response to a compiler error I saw, and wasn't
thinking very carefully about what I was doing.

Fixed.

+
 protected:
     HTMLPlugInElement(const QualifiedName& tagName, Document&, bool createdByParser, PreferPlugInsForImagesOption);
 
     // Node functions:
     virtual void didMoveToNewDocument(Document& oldDocument) OVERRIDE;
     virtual bool dispatchBeforeLoadEvent(const String& sourceURL) OVERRIDE;
 
     // Element functions:
     virtual bool isPresentationAttribute(const QualifiedName&) const OVERRIDE;
     virtual void collectStyleForPresentationAttribute(const QualifiedName&, const AtomicString&, MutableStylePropertySet*) OVERRIDE;
@@ skipping 54 matching lines @@
     bool loadPlugin(const KURL&, const String& mimeType, const Vector<String>& paramNames, const Vector<String>& paramValues, bool useFallback);
     bool pluginIsLoadable(const KURL&, const String& mimeType);
 
     mutable RefPtr<SharedPersistent<v8::Object> > m_pluginWrapper;
     NPObject* m_NPObject;
     bool m_isCapturingMouseEvents;
     bool m_inBeforeLoadEventHandler;
     bool m_needsWidgetUpdate;
     bool m_shouldPreferPlugInsForImages;
     DisplayState m_displayState;
+
+    // Keep track of any plugins that wish to be persisted.
+    RefPtr<Widget> m_plugin;
+    String m_pluginMimeType;
 };
 
 DEFINE_NODE_TYPE_CASTS(HTMLPlugInElement, isPluginElement());
 
 } // namespace WebCore
 
 #endif // HTMLPlugInElement_h