BrowserPlugin/WebView - Move plugin lifetime to DOM

Source/core/html/HTMLObjectElement.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2000 Stefan Schimanski (1Stein@gmx.de)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2011 Apple Inc. All rights reserved.
  * Copyright (C) 2008 Nokia Corporation and/or its subsidiary(-ies)
  *
  * This library is free software; you can redistribute it and/or
  * modify it under the terms of the GNU Library General Public
  * License as published by the Free Software Foundation; either
@@ skipping 79 matching lines @@
 void HTMLObjectElement::parseAttribute(const QualifiedName& name, const AtomicString& value)
 {
     if (name == formAttr)
         formAttributeChanged();
     else if (name == typeAttr) {
         m_serviceType = value.lower();
         size_t pos = m_serviceType.find(";");
         if (pos != kNotFound)
             m_serviceType = m_serviceType.left(pos);
         if (renderer())
             setNeedsWidgetUpdate(true);

[eseidel, 2013/11/18 22:26:45]

I take it we're trying to avoid synchronously creating the plugin at this
callstack?  Presumably because plugin creation can do all sorts of things and
may cause us to reenter?

[wjmaclean, 2013/11/25 17:51:56]

This needs to be investigated further, but I'm guessing if re-entrancy is
possible, it's due to layout issues. Would that be a problem if we are creating
the plugin without a renderer?

Nonetheless, I've tried the approach of calling setNeedsWidgetUpdate(true) with
or without a renderer and then in HTMLPlugInElement::updateWidgetIfNecessary()
create the plugin without a renderer for supported plugin types. So far so good,
but I'm continuing to test it ...

+        else
+            createPluginWithoutRenderer(m_serviceType);
     } else if (name == dataAttr) {
         m_url = stripLeadingAndTrailingHTMLSpaces(value);
         if (renderer()) {
             setNeedsWidgetUpdate(true);
             if (isImageType()) {
                 if (!m_imageLoader)
                     m_imageLoader = adoptPtr(new HTMLImageLoader(this));
                 m_imageLoader->updateFromElementIgnoringPreviousError();
             }
         }
@@ skipping 333 matching lines @@
 {
     return FormAssociatedElement::form();
 }
 
 bool HTMLObjectElement::isInteractiveContent() const
 {
     return fastHasAttribute(usemapAttr);
 }
 
 }