headless/lib/browser/headless_devtools_manager_delegate.h - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: headless/lib/browser/headless_devtools_manager_delegate.h

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: headless/lib/browser/headless_devtools_manager_delegate.h

diff --git a/headless/lib/browser/headless_devtools_manager_delegate.h b/headless/lib/browser/headless_devtools_manager_delegate.h

index 088c247e5c95197b6a994c6772e0ce46bfc69bd6..4d43fc76b79559b3bb0e054110a7be9632858903 100644

--- a/headless/lib/browser/headless_devtools_manager_delegate.h

+++ b/headless/lib/browser/headless_devtools_manager_delegate.h

@@ -27,9 +27,6 @@ class HeadlessDevToolsManagerDelegate

~HeadlessDevToolsManagerDelegate() override;

// DevToolsManagerDelegate implementation:

- void Inspect(content::DevToolsAgentHost* agent_host) override {}

- void DevToolsAgentStateChanged(content::DevToolsAgentHost* agent_host,

- bool attached) override{};

base::DictionaryValue* HandleCommand(content::DevToolsAgentHost* agent_host,

base::DictionaryValue* command) override;

std::string GetDiscoveryPageHTML() override;