content/shell/browser/shell_devtools_manager_delegate.h - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/shell/browser/shell_devtools_manager_delegate.h

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/shell/browser/shell_devtools_manager_delegate.h

diff --git a/content/shell/browser/shell_devtools_manager_delegate.h b/content/shell/browser/shell_devtools_manager_delegate.h

index 1d4ecbcd4843e1bf1a61654a3c916b94f8905dbf..63c875659fbaa2ceebc314b3c1ddf47ea5fac52d 100644

--- a/content/shell/browser/shell_devtools_manager_delegate.h

+++ b/content/shell/browser/shell_devtools_manager_delegate.h

@@ -23,9 +23,6 @@ class ShellDevToolsManagerDelegate : public DevToolsManagerDelegate {

~ShellDevToolsManagerDelegate() override;

// DevToolsManagerDelegate implementation.

- void Inspect(DevToolsAgentHost* agent_host) override {}

- void DevToolsAgentStateChanged(DevToolsAgentHost* agent_host,

- bool attached) override {}

scoped_refptr<DevToolsAgentHost> CreateNewTarget(const GURL& url) override;

std::string GetDiscoveryPageHTML() override;

std::string GetFrontendResource(const std::string& path) override;