content/public/browser/devtools_agent_host.h - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/devtools_agent_host.h

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: make device hosts profile-independent, plump browser context for inspect. Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/devtools_agent_host.h

diff --git a/content/public/browser/devtools_agent_host.h b/content/public/browser/devtools_agent_host.h

index ed5394b475cb3b2a1e8475972a8777a897fb860f..91a9292ff6f3e2c12ecdfc2a7cff3fe34d51bfb7 100644

--- a/content/public/browser/devtools_agent_host.h

+++ b/content/public/browser/devtools_agent_host.h

@@ -187,7 +187,9 @@ class CONTENT_EXPORT DevToolsAgentHost

virtual bool Activate() = 0;

// Opens devtools for this agent host. Returns false if the operation failed.

- virtual bool Inspect() = 0;

+ // If own context is null, uses |context| to open devtools

dgozman 2016/09/22 17:13:59 This should be enforced in content rather than in

+ // window in.

+ virtual bool Inspect(BrowserContext* context) = 0;

// Reloads the host.

virtual void Reload() = 0;