DevTools: untangle device discovery request from the devtools android bridge.

DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)

Committed: https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac
Cr-Commit-Position: refs/heads/master@{#420633}

[pfeldman, 2016-09-21 21:43:46]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-09-21 23:25:24]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-21 23:25:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 02:21:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 02:21:49]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-09-22 05:50:28]

PTAL!

[dgozman, 2016-09-22 17:13:59]

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/android/...
File chrome/browser/android/devtools_manager_delegate_android.cc (right):

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/android/...
chrome/browser/android/devtools_manager_delegate_android.cc:100: return
agent_host_->Inspect(context);
It's strange to pass BrowserContext in just so that it is passed out to this
class.
Overall, maybe we should not expose public Inspect() on DevToolsAgentHost and
make it one-way API from content to embedder?

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.cc (right):

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:410:
DevToolsAgentHost::GetForId(local_id);
This essentially makes it cross-profile.

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:581:
DevToolsAndroidBridge::RemotePage::CreateTarget() {
CreateAgentHost

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.cc:586: std::string type
= GetStringProperty(dict_.get(), "type");
kTypeProperty

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
File chrome/browser/devtools/device/devtools_android_bridge.h (right):

https://codereview.chromium.org/2361613002/diff/20001/chrome/browser/devtools...
chrome/browser/devtools/device/devtools_android_bridge.h:80:
scoped_refptr<AndroidDeviceManager::Device> device_;
Now everyone retains the device?

https://codereview.chromium.org/2361613002/diff/20001/content/public/browser/...
File content/public/browser/devtools_agent_host.h (right):

https://codereview.chromium.org/2361613002/diff/20001/content/public/browser/...
content/public/browser/devtools_agent_host.h:190: // If own context is null,
uses |context| to open devtools
This should be enforced in content rather than in embedder, as it's done now.

[pfeldman, 2016-09-22 19:29:23]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 19:29:47]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 19:49:14]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 19:49:15]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2016-09-22 20:35:47]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 20:37:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-22 21:01:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-22 21:01:07]

Dry run: Try jobs failed on following builders:
  android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)

[pfeldman, 2016-09-22 21:36:02]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 21:36:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[pfeldman, 2016-09-22 21:40:55]

PTAL

[dgozman, 2016-09-23 01:05:28]

lgtm

https://codereview.chromium.org/2361613002/diff/100001/chrome/browser/devtool...
File chrome/browser/devtools/chrome_devtools_manager_delegate.h (right):

https://codereview.chromium.org/2361613002/diff/100001/chrome/browser/devtool...
chrome/browser/devtools/chrome_devtools_manager_delegate.h:15: class
BrowserContext;
Unused.

https://codereview.chromium.org/2361613002/diff/100001/content/public/browser...
File content/public/browser/devtools_agent_host.h (right):

https://codereview.chromium.org/2361613002/diff/100001/content/public/browser...
content/public/browser/devtools_agent_host.h:186: // Returns the favicon url for
this host.
Wrong comment.

https://codereview.chromium.org/2361613002/diff/100001/content/public/browser...
File content/public/browser/devtools_external_agent_proxy_delegate.h (right):

https://codereview.chromium.org/2361613002/diff/100001/content/public/browser...
content/public/browser/devtools_external_agent_proxy_delegate.h:14: class
BrowserContext;
Unused.

[pfeldman, 2016-09-23 01:10:55]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 01:11:21]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 03:18:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 03:18:05]

Dry run: This issue passed the CQ dry run.

[pfeldman, 2016-09-23 14:55:27]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-23 14:55:39]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 15:04:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 15:04:25]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[pfeldman, 2016-09-23 16:34:38]

Description was changed from

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
==========

to

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)
==========

[pfeldman, 2016-09-23 16:34:45]

The CQ bit was checked by pfeldman@chromium.org

[commit-bot: I haz the power, 2016-09-23 16:35:12]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 16:42:11]

Description was changed from

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)
==========

to

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)
==========

[commit-bot: I haz the power, 2016-09-23 16:42:12]

Committed patchset #6 (id:100001)

[commit-bot: I haz the power, 2016-09-23 16:45:08]

Description was changed from

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)
==========

to

==========
DevTools: untangle device discovery request from the devtools android bridge.

BUG=627517
TBR=(api change)

Committed: https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac
Cr-Commit-Position: refs/heads/master@{#420633}
==========

[commit-bot: I haz the power, 2016-09-23 16:45:10]

Patchset 6 (id:??) landed as
https://crrev.com/e7d2e41de976b5fc40bedb9165ef243b3a7254ac
Cr-Commit-Position: refs/heads/master@{#420633}