third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js - Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

Issue 2361613002: DevTools: untangle device discovery request from the devtools android bridge. (Closed)

Patch Set: for landing Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/public/browser/devtools_external_agent_proxy_delegate.h ('K') | « headless/lib/browser/headless_devtools_manager_delegate.h ('k') | third_party/WebKit/Source/devtools/front_end/externs.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

diff --git a/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js b/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

index a06c3d64536b06c6ebcea3b82dd8524024c9179a..24c9dd3f6e062765bce74476ed6f5631aafd37f4 100644

--- a/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

+++ b/third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js

@@ -634,7 +634,7 @@ WebInspector.DevicesView.DeviceView.prototype = {

section.url.textContent = "";

section.url.appendChild(WebInspector.linkifyURLAsNode(page.url, undefined, undefined, true));

}

- section.inspect.disabled = page.adbAttachedForeign;

+ section.inspect.disabled = page.attached;

section.page = page;