DevTools: untangle device discovery request from the devtools android bridge.

chrome/browser/android/devtools_manager_delegate_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/devtools_manager_delegate_android.h"
 
 #include "base/bind.h"
 #include "base/memory/ptr_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 76 matching lines @@
 
   bool Activate() override {
     TabModel* model;
     int index;
     if (!FindTab(&model, &index))
       return false;
     model->SetActiveIndex(index);
     return true;
   }
 
-  bool Inspect() override {
+  bool Inspect(content::BrowserContext* context) override {
     MaterializeAgentHost();
     if (agent_host_)
-      return agent_host_->Inspect();
+      return agent_host_->Inspect(context);

[dgozman, 2016/09/22 17:13:59]

It's strange to pass BrowserContext in just so that it is passed out to this
class.
Overall, maybe we should not expose public Inspect() on DevToolsAgentHost and
make it one-way API from content to embedder?

     return false;
   }
 
   void Reload() override {
     MaterializeAgentHost();
     if (agent_host_)
       agent_host_->Reload();
   }
 
   bool Close() override {
@@ skipping 50 matching lines @@
 
 } //  namespace
 
 DevToolsManagerDelegateAndroid::DevToolsManagerDelegateAndroid()
     : network_protocol_handler_(new DevToolsNetworkProtocolHandler()) {
 }
 
 DevToolsManagerDelegateAndroid::~DevToolsManagerDelegateAndroid() {
 }
 
-void DevToolsManagerDelegateAndroid::Inspect(
-    DevToolsAgentHost* agent_host) {
-}
-
 base::DictionaryValue* DevToolsManagerDelegateAndroid::HandleCommand(
     DevToolsAgentHost* agent_host,
     base::DictionaryValue* command_dict) {
   return network_protocol_handler_->HandleCommand(agent_host, command_dict);
 }
 
 std::string DevToolsManagerDelegateAndroid::GetTargetType(
     content::RenderFrameHost* host) {
   content::WebContents* web_contents =
       content::WebContents::FromRenderFrameHost(host);
@@ skipping 78 matching lines @@
 
 std::string DevToolsManagerDelegateAndroid::GetDiscoveryPageHTML() {
   return ResourceBundle::GetSharedInstance().GetRawDataResource(
       IDR_DEVTOOLS_DISCOVERY_PAGE_HTML).as_string();
 }
 
 void DevToolsManagerDelegateAndroid::DevToolsAgentStateChanged(
     DevToolsAgentHost* agent_host, bool attached) {
   network_protocol_handler_->DevToolsAgentStateChanged(agent_host, attached);
 }