Sync IntersectionObserver IDL with the spec

Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org

Committed: https://crrev.com/48148bd46de9c859248bd65ab770fce3fb4157cd
Cr-Commit-Position: refs/heads/master@{#422322}

[foolip, 2016-09-23 22:15:38]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 22:16:33]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 22:57:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 22:57:07]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[foolip, 2016-09-30 20:57:13]

foolip@chromium.org changed reviewers:
+ szager@chromium.org
- szager@hromium.org

[foolip, 2016-09-30 20:57:13]

Oops, typo in email :) PTAL?

[foolip, 2016-09-30 20:57:21]

Description was changed from

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@hromium.org
==========

to

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org
==========

[foolip, 2016-09-30 20:57:35]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 20:57:57]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-30 21:08:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-30 21:08:29]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[foolip, 2016-09-30 23:09:21]

The CQ bit was checked by foolip@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-30 23:09:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[szager1, 2016-10-01 00:03:30]

lgtm with nits

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserver.idl (right):

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserver.idl:19: // TODO(szager):
|thresholds| is sequence<double> in the spec.
I don't think this needs a TODO here, because there's nothing to do in the code.
 The github issue is sufficient.

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl (left):

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl:8:
RuntimeEnabled=IntersectionObserver
Can you remove RuntimeEnabled=IntersectionObserver from the rest of the files in
this CL?

[commit-bot: I haz the power, 2016-10-01 00:42:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-01 00:42:58]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[foolip, 2016-10-01 15:23:20]

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserver.idl (right):

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserver.idl:19: // TODO(szager):
|thresholds| is sequence<double> in the spec.
On 2016/10/01 00:03:30, szager1 wrote:
> I don't think this needs a TODO here, because there's nothing to do in the
code.
>  The github issue is sufficient.

Will drop TODO.

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl (left):

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl:8:
RuntimeEnabled=IntersectionObserver
On 2016/10/01 00:03:30, szager1 wrote:
> Can you remove RuntimeEnabled=IntersectionObserver from the rest of the files
in
> this CL?

I actually removed it since [RuntimeEnabled] doesn't do anything for
dicionaries, but instead I'll restore this and remove it from all dictionaries
separately.

[foolip, 2016-10-01 15:26:17]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-01 15:26:18]

The patchset sent to the CQ was uploaded after l-g-t-m from szager@chromium.org
Link to the patchset: https://codereview.chromium.org/2361303003/#ps60001
(title: "nits")

[commit-bot: I haz the power, 2016-10-01 15:26:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[foolip, 2016-10-01 15:33:18]

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl (left):

https://codereview.chromium.org/2361303003/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/dom/IntersectionObserverInit.idl:8:
RuntimeEnabled=IntersectionObserver
On 2016/10/01 15:23:20, foolip wrote:
> On 2016/10/01 00:03:30, szager1 wrote:
> > Can you remove RuntimeEnabled=IntersectionObserver from the rest of the
files
> in
> > this CL?
> 
> I actually removed it since [RuntimeEnabled] doesn't do anything for
> dicionaries, but instead I'll restore this and remove it from all dictionaries
> separately.

https://codereview.chromium.org/2390483002

I'll leave dropping the IntersectionObserver REF entirely to someone else :)

[commit-bot: I haz the power, 2016-10-01 17:00:53]

Description was changed from

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org
==========

to

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org
==========

[commit-bot: I haz the power, 2016-10-01 17:00:54]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-01 17:02:26]

Description was changed from

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org
==========

to

==========
Sync IntersectionObserver IDL with the spec

BUG=460722
R=szager@chromium.org

Committed: https://crrev.com/48148bd46de9c859248bd65ab770fce3fb4157cd
Cr-Commit-Position: refs/heads/master@{#422322}
==========

[commit-bot: I haz the power, 2016-10-01 17:02:27]

Patchset 4 (id:??) landed as
https://crrev.com/48148bd46de9c859248bd65ab770fce3fb4157cd
Cr-Commit-Position: refs/heads/master@{#422322}