Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Unified Diff: third_party/WebKit/Source/core/dom/IntersectionObserver.idl

Issue 2361303003: Sync IntersectionObserver IDL with the spec (Closed)
Patch Set: nits Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/dom/IntersectionObserver.idl
diff --git a/third_party/WebKit/Source/core/dom/IntersectionObserver.idl b/third_party/WebKit/Source/core/dom/IntersectionObserver.idl
index fa93787bb29a0f22d08310027d41c827ddc8eaf3..a3464bfbdb4a58ab7e3e0d3d0226afa926b11d46 100644
--- a/third_party/WebKit/Source/core/dom/IntersectionObserver.idl
+++ b/third_party/WebKit/Source/core/dom/IntersectionObserver.idl
@@ -2,22 +2,24 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-// TODO(szager): Update the doc link when the spec has an official home; for now it's:
-// https://github.com/WICG/IntersectionObserver
+// https://wicg.github.io/IntersectionObserver/#intersection-observer-callback
callback IntersectionObserverCallback = void (sequence<IntersectionObserverEntry> entries, IntersectionObserver observer);
+// https://wicg.github.io/IntersectionObserver/#intersection-observer-interface
+
[
- CustomConstructor(IntersectionObserverCallback callback, IntersectionObserverInit options),
+ CustomConstructor(IntersectionObserverCallback callback, optional IntersectionObserverInit options),
Custom=VisitDOMWrapper,
MeasureAs=IntersectionObserver_Constructor,
RuntimeEnabled=IntersectionObserver,
] interface IntersectionObserver {
+ readonly attribute Element? root;
+ readonly attribute DOMString rootMargin;
+ // https://github.com/WICG/IntersectionObserver/issues/114
+ readonly attribute FrozenArray<double> thresholds;
[RaisesException] void observe(Element target);
[RaisesException] void unobserve(Element target);
[RaisesException] void disconnect();
[RaisesException] sequence<IntersectionObserverEntry> takeRecords();
- readonly attribute Element? root;
- readonly attribute DOMString rootMargin;
- readonly attribute FrozenArray<double> thresholds;
};

Powered by Google App Engine
This is Rietveld 408576698