Drop [RuntimeEnabled] for all IDL dictionaries

Drop [RuntimeEnabled] for all IDL dictionaries

Like enums, typedefs, etc., dictionaries aren't observable unless used,
and the generated code does not change by removing [RuntimeEnabled].

R=bashi@chromium.org

Committed: https://crrev.com/18d3734940ccbc96eff5246e2d6235145d44a59e
Cr-Commit-Position: refs/heads/master@{#427039}

[haraken, 2016-10-01 15:52:18]

I was asking patch authors to add [RuntimeEnabled] on dictionaries, but your
point makes more sense.

Can we add some assert to the IDL compiler to clarify that [RuntimeEnabled] is
not needed on dictionaries, enums and typedefs?

[foolip, 2016-10-01 23:13:50]

On 2016/10/01 15:52:18, haraken wrote:
> I was asking patch authors to add [RuntimeEnabled] on dictionaries, but your
> point makes more sense.
> 
> Can we add some assert to the IDL compiler to clarify that [RuntimeEnabled] is
> not needed on dictionaries, enums and typedefs?

Done for dictionaries, which revealed that I missed cases not on the form ']
dictionary'.

I've looked for a good place to make this more generic, but the closest thing is
the IDLExtendedAttributeValidator which traverses all definitions and checks
some things, but nothing specific to any extended attribute.

I did find two enums with [RuntimeEnabled], so it seems worth fixing. Maybe all
extended attributes in IDLExtendedAttributes.txt should declare in which
contexts they can be used? Other ideas?

[bashi, 2016-10-04 06:21:40]

Sorry for the delay (I missed this). lgtm on my side.

[foolip, 2016-10-04 08:50:20]

On 2016/10/04 06:21:40, bashi1 wrote:
> Sorry for the delay (I missed this). lgtm on my side.

Thanks! What are your thoughts on the same check for enums and typedefs? Does
the IDLExtendedAttributes.txt idea sound sensible, or is there a better place?

[bashi, 2016-10-04 09:34:38]

On 2016/10/04 08:50:20, foolip wrote:
> On 2016/10/04 06:21:40, bashi1 wrote:
> > Sorry for the delay (I missed this). lgtm on my side.
> 
> Thanks! What are your thoughts on the same check for enums and typedefs? Does
> the IDLExtendedAttributes.txt idea sound sensible, or is there a better place?

I think IDLExtendedAttributeValidator is a good place to do some validations
including [RuntimeEnabled]. We'd appreciate it if you could do that :)

[foolip, 2016-10-24 08:36:06]

On 2016/10/04 09:34:38, bashi1 wrote:
> On 2016/10/04 08:50:20, foolip wrote:
> > On 2016/10/04 06:21:40, bashi1 wrote:
> > > Sorry for the delay (I missed this). lgtm on my side.
> > 
> > Thanks! What are your thoughts on the same check for enums and typedefs?
Does
> > the IDLExtendedAttributes.txt idea sound sensible, or is there a better
place?
> 
> I think IDLExtendedAttributeValidator is a good place to do some validations
> including [RuntimeEnabled]. We'd appreciate it if you could do that :)

I've left this CL open hoping to get some time for that, but it'd probably take
a few hours to sort through everything and make sure that the annotations match
what's supported and not just what happens to be used. So I'll land this CL
as-is and maybe consider that if there's another case of widespread incorrect
use to trigger it.

[foolip, 2016-10-24 08:49:26]

The CQ bit was checked by foolip@chromium.org

[foolip, 2016-10-24 08:49:26]

The patchset sent to the CQ was uploaded after l-g-t-m from bashi@chromium.org
Link to the patchset: https://codereview.chromium.org/2390483002/#ps40001
(title: "rebase")

[commit-bot: I haz the power, 2016-10-24 08:49:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-24 10:21:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-24 10:25:00]

Description was changed from

==========
Drop [RuntimeEnabled] for all IDL dictionaries

Like enums, typedefs, etc., dictionaries aren't observable unless used,
and the generated code does not change by removing [RuntimeEnabled].

R=bashi@chromium.org
==========

to

==========
Drop [RuntimeEnabled] for all IDL dictionaries

Like enums, typedefs, etc., dictionaries aren't observable unless used,
and the generated code does not change by removing [RuntimeEnabled].

R=bashi@chromium.org

Committed: https://crrev.com/18d3734940ccbc96eff5246e2d6235145d44a59e
Cr-Commit-Position: refs/heads/master@{#427039}
==========

[commit-bot: I haz the power, 2016-10-24 10:25:01]

Patchset 3 (id:??) landed as
https://crrev.com/18d3734940ccbc96eff5246e2d6235145d44a59e
Cr-Commit-Position: refs/heads/master@{#427039}