Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(574)

Unified Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 236113002: Suppress tabs permission warning if there is already a browsingHistory warning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/common/permissions/permissions_data_unittest.cc
diff --git a/extensions/common/permissions/permissions_data_unittest.cc b/extensions/common/permissions/permissions_data_unittest.cc
index 2ebc9ba11b2a0eb3b0f05c0dff0b8f062b2aaa0a..c1596167b2d21c4d17a903b9f2886de08f280c87 100644
--- a/extensions/common/permissions/permissions_data_unittest.cc
+++ b/extensions/common/permissions/permissions_data_unittest.cc
@@ -158,15 +158,15 @@ TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) {
extension = LoadManifest("permissions", "many-apis.json");
std::vector<base::string16> warnings =
PermissionsData::GetPermissionMessageStrings(extension.get());
- ASSERT_EQ(6u, warnings.size());
+ // Warning for "tabs" is suppressed by "history" permission.
+ ASSERT_EQ(5u, warnings.size());
EXPECT_EQ("Access your data on api.flickr.com",
UTF16ToUTF8(warnings[0]));
EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1]));
EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3]));
- EXPECT_EQ("Access your tabs and browsing activity", UTF16ToUTF8(warnings[4]));
EXPECT_EQ("Manage your apps, extensions, and themes",
- UTF16ToUTF8(warnings[5]));
+ UTF16ToUTF8(warnings[4]));
}
TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698