chrome/test/data/extensions/api_test/management/test/basics.js - Issue 236113002: Suppress tabs permission warning if there is already a browsingHistory warning.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/data/extensions/api_test/management/test/basics.js

Issue 236113002: Suppress tabs permission warning if there is already a browsingHistory warning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix tests Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/common/extensions/permissions/permission_set_unittest.cc ('k') | extensions/common/permissions/permissions_data_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/test/data/extensions/api_test/management/test/basics.js

diff --git a/chrome/test/data/extensions/api_test/management/test/basics.js b/chrome/test/data/extensions/api_test/management/test/basics.js

index 915843b5d8ef963712317e6b03162045182e2ada..78c7a6e814d65bebb5e958340e637fae0ca5bccd 100644

--- a/chrome/test/data/extensions/api_test/management/test/basics.js

+++ b/chrome/test/data/extensions/api_test/management/test/basics.js

@@ -107,15 +107,14 @@ var tests = [

chrome.management.getPermissionWarningsByManifest(

manifest_str, callback(function(warnings) {

- chrome.test.assertEq(5, warnings.length);

+ // Warning for "tabs" is suppressed by "history" permission.

+ chrome.test.assertEq(4, warnings.length);

chrome.test.assertEq(

"Access your data on *.flickr.com and api.flickr.com", warnings[0]);

chrome.test.assertEq("Read and modify your bookmarks", warnings[1]);

chrome.test.assertEq("Detect your physical location", warnings[2]);

chrome.test.assertEq("Read and modify your browsing history",

warnings[3]);

- chrome.test.assertEq("Access your tabs and browsing activity",

- warnings[4]);

}));

chrome.management.getAll(callback(function(items) {