Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Side by Side Diff: extensions/common/permissions/permissions_data_unittest.cc

Issue 236113002: Suppress tabs permission warning if there is already a browsingHistory warning. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix tests Created 6 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <vector> 5 #include <vector>
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "base/memory/ref_counted.h" 8 #include "base/memory/ref_counted.h"
9 #include "base/strings/string16.h" 9 #include "base/strings/string16.h"
10 #include "base/strings/utf_string_conversions.h" 10 #include "base/strings/utf_string_conversions.h"
(...skipping 140 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 extension, 151 extension,
152 SocketPermissionRequest::UDP_SEND_TO, 152 SocketPermissionRequest::UDP_SEND_TO,
153 "239.255.255.250", 1900)); 153 "239.255.255.250", 1900));
154 } 154 }
155 155
156 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) { 156 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyAPIPermissions) {
157 scoped_refptr<Extension> extension; 157 scoped_refptr<Extension> extension;
158 extension = LoadManifest("permissions", "many-apis.json"); 158 extension = LoadManifest("permissions", "many-apis.json");
159 std::vector<base::string16> warnings = 159 std::vector<base::string16> warnings =
160 PermissionsData::GetPermissionMessageStrings(extension.get()); 160 PermissionsData::GetPermissionMessageStrings(extension.get());
161 ASSERT_EQ(6u, warnings.size()); 161 // Warning for "tabs" is suppressed by "history" permission.
162 ASSERT_EQ(5u, warnings.size());
162 EXPECT_EQ("Access your data on api.flickr.com", 163 EXPECT_EQ("Access your data on api.flickr.com",
163 UTF16ToUTF8(warnings[0])); 164 UTF16ToUTF8(warnings[0]));
164 EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1])); 165 EXPECT_EQ("Read and modify your bookmarks", UTF16ToUTF8(warnings[1]));
165 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2])); 166 EXPECT_EQ("Detect your physical location", UTF16ToUTF8(warnings[2]));
166 EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3])); 167 EXPECT_EQ("Read and modify your browsing history", UTF16ToUTF8(warnings[3]));
167 EXPECT_EQ("Access your tabs and browsing activity", UTF16ToUTF8(warnings[4]));
168 EXPECT_EQ("Manage your apps, extensions, and themes", 168 EXPECT_EQ("Manage your apps, extensions, and themes",
169 UTF16ToUTF8(warnings[5])); 169 UTF16ToUTF8(warnings[4]));
170 } 170 }
171 171
172 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) { 172 TEST(ExtensionPermissionsTest, GetPermissionMessages_ManyHostsPermissions) {
173 scoped_refptr<Extension> extension; 173 scoped_refptr<Extension> extension;
174 extension = LoadManifest("permissions", "more-than-3-hosts.json"); 174 extension = LoadManifest("permissions", "more-than-3-hosts.json");
175 std::vector<base::string16> warnings = 175 std::vector<base::string16> warnings =
176 PermissionsData::GetPermissionMessageStrings(extension.get()); 176 PermissionsData::GetPermissionMessageStrings(extension.get());
177 std::vector<base::string16> warnings_details = 177 std::vector<base::string16> warnings_details =
178 PermissionsData::GetPermissionMessageDetailsStrings(extension.get()); 178 PermissionsData::GetPermissionMessageDetailsStrings(extension.get());
179 ASSERT_EQ(1u, warnings.size()); 179 ASSERT_EQ(1u, warnings.size());
(...skipping 452 matching lines...) Expand 10 before | Expand all | Expand 10 after
632 PermissionsData::ClearTabSpecificPermissions(extension.get(), 1); 632 PermissionsData::ClearTabSpecificPermissions(extension.get(), 1);
633 EXPECT_FALSE(PermissionsData::GetTabSpecificPermissions(extension.get(), 1) 633 EXPECT_FALSE(PermissionsData::GetTabSpecificPermissions(extension.get(), 1)
634 .get()); 634 .get());
635 635
636 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0)); 636 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 0));
637 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1)); 637 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 1));
638 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2)); 638 EXPECT_TRUE(ScriptAllowedExclusivelyOnTab(extension.get(), no_urls, 2));
639 } 639 }
640 640
641 } // namespace extensions 641 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/test/data/extensions/api_test/management/test/basics.js ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698