net/cert/internal/verify_certificate_chain_unittest.cc - Issue 2360953002: Add some more TODOs for places to instrument certificate errors.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/cert/internal/verify_certificate_chain_unittest.cc

Issue 2360953002: Add some more TODOs for places to instrument certificate errors. (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/cert/internal/verify_certificate_chain_unittest.cc

diff --git a/net/cert/internal/verify_certificate_chain_unittest.cc b/net/cert/internal/verify_certificate_chain_unittest.cc

index bfb4b62c246d5f996e1bf4f7591e442716c7ba22..ec5f637a5a54127638c0d1cf0417e7c6a2f45283 100644

--- a/net/cert/internal/verify_certificate_chain_unittest.cc

+++ b/net/cert/internal/verify_certificate_chain_unittest.cc

@@ -30,6 +30,8 @@ class VerifyCertificateChainDelegate {

EXPECT_EQ(expected_result, result);

EXPECT_EQ(expected_errors, errors.ToDebugString()) << "Test file: "

<< test_file_path;

+ if (!result)

+ EXPECT_FALSE(errors.empty());

}

};