Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: net/cert/internal/verify_signed_data_unittest.cc

Issue 2360953002: Add some more TODOs for places to instrument certificate errors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « net/cert/internal/verify_certificate_chain_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/cert/internal/verify_signed_data_unittest.cc
diff --git a/net/cert/internal/verify_signed_data_unittest.cc b/net/cert/internal/verify_signed_data_unittest.cc
index 470aec4e634d7ac6383818cadcd5e6159c436aa5..7710abc47f2f5cb8ffed7e5b65467bc4e70e1ec7 100644
--- a/net/cert/internal/verify_signed_data_unittest.cc
+++ b/net/cert/internal/verify_signed_data_unittest.cc
@@ -67,12 +67,15 @@ void RunTestCaseUsingPolicy(VerifyResult expected_result,
bool expected_result_bool = expected_result == SUCCESS;
- // TODO(crbug.com/634443): Verify the returned errors.
CertErrors verify_errors;
- EXPECT_EQ(expected_result_bool,
- VerifySignedData(*signature_algorithm, der::Input(&signed_data),
- signature_value_bit_string,
- der::Input(&public_key), policy, &verify_errors));
+ bool result =
+ VerifySignedData(*signature_algorithm, der::Input(&signed_data),
+ signature_value_bit_string, der::Input(&public_key),
+ policy, &verify_errors);
+ EXPECT_EQ(expected_result_bool, result);
+ // TODO(crbug.com/634443): Verify the returned errors.
+ // if (!result)
+ // EXPECT_FALSE(verify_errors.empty());
}
// RunTestCase() is the same as RunTestCaseUsingPolicy(), only it uses a
« no previous file with comments | « net/cert/internal/verify_certificate_chain_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698