Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(159)

Unified Diff: net/cert/internal/verify_certificate_chain_pkits_unittest.cc

Issue 2360953002: Add some more TODOs for places to instrument certificate errors. (Closed)
Patch Set: Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/cert/internal/verify_certificate_chain_pkits_unittest.cc
diff --git a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
index 9bdb8502cd853c522d73a8fdaa8a870ead91df46..6e2209a0f7ae55599391dd4ffc8607734f1357a8 100644
--- a/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
+++ b/net/cert/internal/verify_certificate_chain_pkits_unittest.cc
@@ -74,9 +74,14 @@ class VerifyCertificateChainPkitsTestDelegate {
// Run all tests at the time the PKITS was published.
der::GeneralizedTime time = {2011, 4, 15, 0, 0, 0};
+ bool result = VerifyCertificateChain(input_chain, trust_anchor.get(),
+ &signature_policy, time, &errors);
+
// TODO(crbug.com/634443): Test errors on failure?
- return VerifyCertificateChain(input_chain, trust_anchor.get(),
- &signature_policy, time, &errors);
+ if (!result)
+ EXPECT_FALSE(errors.empty());
+
+ return result;
}
};
« no previous file with comments | « net/cert/internal/signature_algorithm_unittest.cc ('k') | net/cert/internal/verify_certificate_chain_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698