shapedetection module: Introduce basic structure for face detection

shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
Committed: https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1
Cr-Commit-Position: refs/heads/master@{#421290}

[xianglu, 2016-09-21 23:10:22]

ptal.

[mcasas, 2016-09-21 23:25:49]

Looking good, couple of comments.

Correct description typos (e.g. "includeing",
"shapdetection", "varify").  Also, bots.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
(right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:10:
}catch(e){
There seems to be way more instances of, e.g.
} catch(...
than of }catch (without the gap): 1025 versus 26
in LayoutTests/fast. The style guide [1] doesn't say
anything about it, however, I'd keep gaps between 
keywords and curly brackets.

[1] https://google.github.io/styleguide/javascriptguide.xml

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:12:
}
Consider using assert_throws, here and in a similar 
fashion in l.17-21

  assert_throws("NotSupportedError",
                function() {
                  var detectedObject = new DetectedObject();
                },
                'DetectedObject should not be instantiable.');

Also, note that, saying "new DetectedObject()..." is 
essentially redundant, since it just describes what the
code is doing. Instead, the proposed message is 
describing the meaning of the test/actions.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:15:
// This test verifies that Detector not can be created
s/not can/can not/

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/DetectedFace.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/DetectedFace.h:15: : public
DetectedObject {
nit: move this to the previous line? Or is this webkit style?

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/Detector.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/Detector.h:31: //         = 0;
Remove these commented out-lines.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:18: return
promise;
I suggest instead of l.17-18:

    resolver->reject(DOMException::create(NotSupportedError, "Not
implemented"));
    return promisel

for the time being.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:28:
HeapVector<Member<DetectedObject>>);
Remove this guy and its commented-out implementation.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl:7: //TODO: add
(optional FaceDetectorOptions faceDetectorOptions)
Missing whitespace between the slashes and 'TODO'

TODOs should be written like:
// TODO(xianglu): Add ... (https://crbug.com/...).

[xianglu, 2016-09-21 23:32:07]

Description was changed from

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, includeing
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapdetection-creation.html to varify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
==========

to

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
==========

[xianglu, 2016-09-22 22:44:15]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 22:45:02]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-09-22 22:48:41]

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html
(right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:10:
}catch(e){
On 2016/09/21 23:25:48, mcasas wrote:
> There seems to be way more instances of, e.g.
> } catch(...
> than of }catch (without the gap): 1025 versus 26
> in LayoutTests/fast. The style guide [1] doesn't say
> anything about it, however, I'd keep gaps between 
> keywords and curly brackets.
> 
> [1] https://google.github.io/styleguide/javascriptguide.xml

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:12:
}
On 2016/09/21 23:25:48, mcasas wrote:
> Consider using assert_throws, here and in a similar 
> fashion in l.17-21
> 
>   assert_throws("NotSupportedError",
>                 function() {
>                   var detectedObject = new DetectedObject();
>                 },
>                 'DetectedObject should not be instantiable.');
> 
> Also, note that, saying "new DetectedObject()..." is 
> essentially redundant, since it just describes what the
> code is doing. Instead, the proposed message is 
> describing the meaning of the test/actions.

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html:15:
// This test verifies that Detector not can be created
On 2016/09/21 23:25:48, mcasas wrote:
> s/not can/can not/

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/DetectedFace.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/DetectedFace.h:15: : public
DetectedObject {
On 2016/09/21 23:25:48, mcasas wrote:
> nit: move this to the previous line? Or is this webkit style?

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/Detector.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/Detector.h:31: //         = 0;
On 2016/09/21 23:25:48, mcasas wrote:
> Remove these commented out-lines.

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.cpp:18: return
promise;
On 2016/09/21 23:25:48, mcasas wrote:
> I suggest instead of l.17-18:
> 
>     resolver->reject(DOMException::create(NotSupportedError, "Not
> implemented"));
>     return promisel
> 
> for the time being.

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:28:
HeapVector<Member<DetectedObject>>);
On 2016/09/21 23:25:48, mcasas wrote:
> Remove this guy and its commented-out implementation.

Done.

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl (right):

https://codereview.chromium.org/2360783003/diff/1/third_party/WebKit/Source/m...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl:7: //TODO: add
(optional FaceDetectorOptions faceDetectorOptions)
On 2016/09/21 23:25:48, mcasas wrote:
> Missing whitespace between the slashes and 'TODO'
> 
> TODOs should be written like:
> // TODO(xianglu): Add ... (https://crbug.com/...).

Done.

[xianglu, 2016-09-22 22:49:25]

xianglu@chromium.org changed reviewers:
+ haraken@chromium.org

[xianglu, 2016-09-22 22:49:28]

ptal. Thanks!

[xianglu, 2016-09-22 23:06:14]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-22 23:06:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 01:00:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 01:00:26]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[xianglu, 2016-09-23 17:26:05]

Patchset #2 (id:20001) has been deleted

[xianglu, 2016-09-23 17:30:29]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:31:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-09-23 17:55:51]

Patchset #2 (id:40001) has been deleted

[xianglu, 2016-09-23 17:56:12]

Patchset #2 (id:60001) has been deleted

[xianglu, 2016-09-23 17:56:47]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-23 17:57:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-23 21:37:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-23 21:37:57]

Dry run: This issue passed the CQ dry run.

[xianglu, 2016-09-26 19:40:59]

xianglu@chromium.org changed reviewers:
+ esprehn@chromium.org

[xianglu, 2016-09-26 19:41:00]

esprehn@ ptal

[haraken, 2016-09-27 14:46:28]

LGTM

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/DetectedObject.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/DetectedObject.h:8: #include
"bindings/core/v8/ScriptPromise.h"

Remove this.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/DetectedObject.h:15: class
DOMRect;

Remove this. You already include DOMRect.h.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/Detector.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:6: #define
THIRD_PARTY_WEBKIT_SOURCE_MODULES_SHAPEDETECTION_DETECTOR_H_

At the moment, Blink uses #define SHAPEDETECTION_DETECTOR_H_. Though it will be
updated when the coding style assimilation project is complete.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:9: #include
"bindings/core/v8/ScriptPromiseResolver.h"

Remove this.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:26:
DEFINE_INLINE_TRACE() {};

Redundant ;

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:8: #include
"bindings/core/v8/ActiveScriptWrappable.h"

Remove this.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:15: class
FaceDetectorOptions;

Remove this.

[xianglu, 2016-09-27 16:44:22]

Patchset #3 (id:100001) has been deleted

[xianglu, 2016-09-27 16:45:09]

The CQ bit was checked by xianglu@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-09-27 16:45:39]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[xianglu, 2016-09-27 16:46:25]

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/DetectedObject.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/DetectedObject.h:8: #include
"bindings/core/v8/ScriptPromise.h"
On 2016/09/27 14:46:27, haraken wrote:
> 
> Remove this.

Done.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/DetectedObject.h:15: class
DOMRect;
On 2016/09/27 14:46:27, haraken wrote:
> 
> Remove this. You already include DOMRect.h.

Done.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/Detector.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:6: #define
THIRD_PARTY_WEBKIT_SOURCE_MODULES_SHAPEDETECTION_DETECTOR_H_
On 2016/09/27 14:46:27, haraken wrote:
> 
> At the moment, Blink uses #define SHAPEDETECTION_DETECTOR_H_. Though it will
be
> updated when the coding style assimilation project is complete.

The SHAPEDETECTION_* header guard doesn't pass the presubmit check, I will
change it in the next CL if possible.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:9: #include
"bindings/core/v8/ScriptPromiseResolver.h"
On 2016/09/27 14:46:27, haraken wrote:
> 
> Remove this.

Done.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/Detector.h:26:
DEFINE_INLINE_TRACE() {};
On 2016/09/27 14:46:27, haraken wrote:
> 
> Redundant ;

In order to make base class GarbageCollected, we need to declare and define
"trace" here to pass the compiler.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:8: #include
"bindings/core/v8/ActiveScriptWrappable.h"
On 2016/09/27 14:46:28, haraken wrote:
> 
> Remove this.

Done.

https://codereview.chromium.org/2360783003/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:15: class
FaceDetectorOptions;
On 2016/09/27 14:46:28, haraken wrote:
> 
> Remove this.

Done.

[commit-bot: I haz the power, 2016-09-27 17:58:35]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-09-27 17:58:36]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[mcasas, 2016-09-27 17:58:51]

lgtm with a nit.

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/Detector.h (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/Detector.h:8: #include
"bindings/core/v8/ScriptPromise.h"
nit: probably not needed (or move to DetectedFace.cpp).

[xianglu, 2016-09-27 18:03:18]

The CQ bit was checked by xianglu@chromium.org

[xianglu, 2016-09-27 18:03:19]

The patchset sent to the CQ was uploaded after l-g-t-m from haraken@chromium.org
Link to the patchset: https://codereview.chromium.org/2360783003/#ps120001
(title: "haraken@ comments")

[commit-bot: I haz the power, 2016-09-27 18:03:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-09-27 19:11:10]

Description was changed from

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
==========

to

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
==========

[commit-bot: I haz the power, 2016-09-27 19:11:11]

Committed patchset #3 (id:120001)

[commit-bot: I haz the power, 2016-09-27 19:14:59]

Description was changed from

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083
==========

to

==========
shapedetection module: Introduce basic structure for face detection

This CL introduces the basic structure of Shape Detection API, including
four classes:
Detector, FaceDetector, DetectedObject, DetectedFace (dictionaries are
not yet implemented)

and adds simple layout tests in shapedetection-creation.html to verify
corresponding constructors.

R=mcasas@chromium.org
BUG=646083

Committed: https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1
Cr-Commit-Position: refs/heads/master@{#421290}
==========

[commit-bot: I haz the power, 2016-09-27 19:15:00]

Patchset 3 (id:??) landed as
https://crrev.com/7ff48d8465a02e51ec7d76e789758006b96ff9b1
Cr-Commit-Position: refs/heads/master@{#421290}

[esprehn, 2016-09-28 04:19:15]

I think there's some confusion in the API surface here. The Dector mixin doesn't
make sense from an idl perspective, and it also seems too complex for a v1 API.
I think you want to reduce this API surface a lot to ship a v1.

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Lay...
File
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt
(right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Lay...
third_party/WebKit/LayoutTests/webexposed/global-interface-listing-dedicated-worker-expected.txt:149:
[Worker] interface Detector
This name is too generic, I don't think we want Detector and DetectedOBject on
window. You're going to need to rename these to ShapeDetector and
ShapeDectorObject or something.

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/DetectedFace.h (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/DetectedFace.h:14: class
MODULES_EXPORT DetectedFace final : public DetectedObject {
Hmm, this object has no members, why do we need it?

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/DetectedFace.idl:13:
DetectedFace implements DetectedObject;
What's the reason for the generic DetectedObject API?

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/Detector.idl (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/Detector.idl:10: ] interface
Detector {
I don't think you want this generic interface and the subclassing, you want to
just have FaceDetector.

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.h (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.h:20:
ScriptPromise detect(ScriptState*, const HTMLImageElement*);
fwiw, this isn't really how the web works. You're trying to do virtual functions
here with that inheritance scheme.

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
File third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl (right):

https://codereview.chromium.org/2360783003/diff/120001/third_party/WebKit/Sou...
third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl:13:
FaceDetector implements Detector;
You're both doing mixins here and adding global interfaces which I think is a
mistake. Did you want [NoInterfaceObject] on the Detector? Also why do we need
both to start? I feel like this API is a bit too complicated for v1