third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html - Issue 2360783003: shapedetection module: Introduce basic structure for face detection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/shapedetection/shapedetection-creation.html

Issue 2360783003: shapedetection module: Introduce basic structure for face detection (Closed)

Patch Set: Created 4 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src=../../resources/testharness.js></script>

	3 <script src=../../resources/testharnessreport.js></script>

	4 <script>

	5

	6 // This test verifies that DetectedObject can not be created

	7 test(function() {

	8 try{

	9 var detectedObject = new DetectedObject();

	10 }catch(e){
	mcasas 2016/09/21 23:25:48 There seems to be way more instances of, e.g. } ca There seems to be way more instances of, e.g. } catch(... than of }catch (without the gap): 1025 versus 26 in LayoutTests/fast. The style guide [1] doesn't say anything about it, however, I'd keep gaps between keywords and curly brackets. [1] https://google.github.io/styleguide/javascriptguide.xml xianglu 2016/09/22 22:48:39 Done. Show quoted text On 2016/09/21 23:25:48, mcasas wrote: > There seems to be way more instances of, e.g. > } catch(... > than of }catch (without the gap): 1025 versus 26 > in LayoutTests/fast. The style guide [1] doesn't say > anything about it, however, I'd keep gaps between > keywords and curly brackets. > > [1] https://google.github.io/styleguide/javascriptguide.xml Done.
	11 assert_true(e instanceof TypeError);

	12 }
	mcasas 2016/09/21 23:25:48 Consider using assert_throws, here and in a simila Consider using assert_throws, here and in a similar fashion in l.17-21 assert_throws("NotSupportedError", function() { var detectedObject = new DetectedObject(); }, 'DetectedObject should not be instantiable.'); Also, note that, saying "new DetectedObject()..." is essentially redundant, since it just describes what the code is doing. Instead, the proposed message is describing the meaning of the test/actions. xianglu 2016/09/22 22:48:40 Done. Show quoted text On 2016/09/21 23:25:48, mcasas wrote: > Consider using assert_throws, here and in a similar > fashion in l.17-21 > > assert_throws("NotSupportedError", > function() { > var detectedObject = new DetectedObject(); > }, > 'DetectedObject should not be instantiable.'); > > Also, note that, saying "new DetectedObject()..." is > essentially redundant, since it just describes what the > code is doing. Instead, the proposed message is > describing the meaning of the test/actions. Done.
	13 }, 'new DetectedObject() should throw illegal constructor exception');

	14

	15 // This test verifies that Detector not can be created
	mcasas 2016/09/21 23:25:48 s/not can/can not/ s/not can/can not/ xianglu 2016/09/22 22:48:39 Done. Show quoted text On 2016/09/21 23:25:48, mcasas wrote: > s/not can/can not/ Done.
	16 test(function() {

	17 try{

	18 var detector = new Detector();

	19 }catch(e){

	20 assert_true(e instanceof TypeError);

	21 }

	22 }, 'new Detector() should throw illegal constructor exception');

	23

	24 // This test verifies that DetectedFace can be created

	25 test(function() {

	26 var detectedFace = new DetectedFace();

	27 assert_true(detectedFace instanceof DetectedFace);

	28 }, 'new DetectedFace()');

	29

	30 // This test verifies that FaceDetector can be created

	31 test(function() {

	32 var faceDetector = new FaceDetector();

	33 assert_true(faceDetector instanceof FaceDetector);

	34 }, 'new FaceDetector()');

	35

	36 </script>

OLD	NEW

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/BUILD.gn » ('j') | third_party/WebKit/Source/modules/shapedetection/DetectedFace.h » ('J')