third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl - Issue 2360783003: shapedetection module: Introduce basic structure for face detection

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/shapedetection/FaceDetector.idl

Issue 2360783003: shapedetection module: Introduce basic structure for face detection (Closed)

Patch Set: haraken@ comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://wicg.github.io/shape-detection-api/#face-detection-api

	6

	7 // TODO(xianglu): Add [Constructor(optional FaceDetectorOptions faceDetectorOpti ons)]. https://crbug.com/646083

	8 [

	9 Constructor,

	10 RuntimeEnabled=ShapeDetection,

	11 ] interface FaceDetector {

	12 };

	13 FaceDetector implements Detector;
	esprehn 2016/09/28 04:19:14 You're both doing mixins here and adding global in You're both doing mixins here and adding global interfaces which I think is a mistake. Did you want [NoInterfaceObject] on the Detector? Also why do we need both to start? I feel like this API is a bit too complicated for v1
OLD	NEW