Use v8::Isolate::GetCurrent() less in custom bindings

Use v8::Isolate::GetCurrent() less in custom bindings

Update custom bindings to avoids calling v8::Isolate::GetCurrent() when we don't
have to.

R=haraken
BUG=263412
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157962

[haraken, 2013-09-18 12:34:00]

LGTM

[commit-bot: I haz the power, 2013-09-18 12:35:13]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/23606036/1

[marja, 2013-09-18 12:36:27]

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
File Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (right):

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:66: v8::HandleScope
scope(value.isolate());
What's this? I don't see ScriptValue::Isolate... does it do something that
requires a HandleScope?

[marja, 2013-09-18 12:37:44]

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
File Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (right):

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:66: v8::HandleScope
scope(value.isolate());
On 2013/09/18 12:36:28, marja wrote:
> What's this? I don't see ScriptValue::Isolate... does it do something that
> requires a HandleScope?

Ahh, you just landed ScriptValue::m_isolate. Hmm, is it ok to store the isolate
in every ScriptValue? At some point I was told not to do that.

[do-not-use, 2013-09-18 12:39:48]

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
File Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp (right):

https://codereview.chromium.org/23606036/diff/1/Source/bindings/v8/custom/V8I...
Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp:66: v8::HandleScope
scope(value.isolate());
On 2013/09/18 12:37:45, marja wrote:
> On 2013/09/18 12:36:28, marja wrote:
> > What's this? I don't see ScriptValue::Isolate... does it do something that
> > requires a HandleScope?
> 
> Ahh, you just landed ScriptValue::m_isolate. Hmm, is it ok to store the
isolate
> in every ScriptValue? At some point I was told not to do that.

Good question. At least no one complained yet :)
I know for example that Dictionary also stores both the v8::Value and the
Isolate.

[commit-bot: I haz the power, 2013-09-18 13:16:56]

Change committed as 157962