Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp

Issue 23606036: Use v8::Isolate::GetCurrent() less in custom bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
diff --git a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
index 7559f4af5848163421ebe268621d142695a4937e..51b25c9c08150a9919d0278e80cdd6ccac219525 100644
--- a/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
+++ b/Source/bindings/v8/custom/V8InjectedScriptHostCustom.cpp
@@ -63,7 +63,7 @@ namespace WebCore {
Node* InjectedScriptHost::scriptValueAsNode(ScriptValue value)
{
- v8::HandleScope scope(v8::Isolate::GetCurrent());
+ v8::HandleScope scope(value.isolate());
marja 2013/09/18 12:36:28 What's this? I don't see ScriptValue::Isolate... d
marja 2013/09/18 12:37:45 Ahh, you just landed ScriptValue::m_isolate. Hmm,
do-not-use 2013/09/18 12:39:49 Good question. At least no one complained yet :) I
if (!value.isObject() || value.isNull())
return 0;
return V8Node::toNative(v8::Handle<v8::Object>::Cast(value.v8Value()));
« no previous file with comments | « Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698