Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Unified Diff: Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp

Issue 23606036: Use v8::Isolate::GetCurrent() less in custom bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp
diff --git a/Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp b/Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp
index 815d5d06ab3ac077bba9ee8a1aa6672d8894f9d8..4dd9b8c77ffcc145ebfc24295dcf14c17bd68de3 100644
--- a/Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp
+++ b/Source/bindings/v8/custom/V8HTMLPlugInElementCustom.cpp
@@ -50,7 +50,7 @@ static void npObjectNamedGetter(v8::Local<v8::String> name, const v8::PropertyCa
if (!scriptInstance)
return;
- v8::Local<v8::Object> instance = scriptInstance->newLocal(v8::Isolate::GetCurrent());
+ v8::Local<v8::Object> instance = scriptInstance->newLocal(info.GetIsolate());
if (instance.IsEmpty())
return;
@@ -65,7 +65,7 @@ static void npObjectNamedSetter(v8::Local<v8::String> name, v8::Local<v8::Value>
if (!scriptInstance)
return;
- v8::Local<v8::Object> instance = scriptInstance->newLocal(v8::Isolate::GetCurrent());
+ v8::Local<v8::Object> instance = scriptInstance->newLocal(info.GetIsolate());
if (instance.IsEmpty())
return;
@@ -125,7 +125,7 @@ void npObjectIndexedGetter(uint32_t index, const v8::PropertyCallbackInfo<v8::Va
if (!scriptInstance)
return;
- v8::Local<v8::Object> instance = scriptInstance->newLocal(v8::Isolate::GetCurrent());
+ v8::Local<v8::Object> instance = scriptInstance->newLocal(info.GetIsolate());
if (instance.IsEmpty())
return;
@@ -140,7 +140,7 @@ void npObjectIndexedSetter(uint32_t index, v8::Local<v8::Value> value, const v8:
if (!scriptInstance)
return;
- v8::Local<v8::Object> instance = scriptInstance->newLocal(v8::Isolate::GetCurrent());
+ v8::Local<v8::Object> instance = scriptInstance->newLocal(info.GetIsolate());
if (instance.IsEmpty())
return;

Powered by Google App Engine
This is Rietveld 408576698