Chromium 284577 needs a mitigation CL added. There is a TODO to remove

Chromium 284577 needs a mitigation CL added. There is a TODO to remove
the mitigation when the cause of the bug is discovered.

BUG=
R=hpayer@chromium.org, mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=16742

[mvstanton, 2013-09-16 15:31:13]

Hi Hannes, here is the code we discussed. Michael, would you take a quick look
at the Heap::Contains() call in objects.cc?
thx,
--Michael

[Hannes Payer (out of office), 2013-09-16 16:12:05]

https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9040
src/objects.cc:9040: object->GetHeap()->Contains(site_address)) {
Instead of checking the whole heap, you could check if the address is in old
pointer space since this is the place where allocation sites should be
allocated.

[Michael Starzinger, 2013-09-16 16:12:56]

LGTM with comment.

https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9037
src/objects.cc:9037: Address site_address = (reinterpret_cast<Address>(site) -
nit: As discussed offline with Hannes, better use
Heap::InOldPointerSpace(Object*) here.

[mvstanton, 2013-09-16 16:38:27]

thx, Hannes, have another look then,
--Michael

https://codereview.chromium.org/23606032/diff/1/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9037
src/objects.cc:9037: Address site_address = (reinterpret_cast<Address>(site) -
On 2013/09/16 16:12:56, Michael Starzinger wrote:
> nit: As discussed offline with Hannes, better use
> Heap::InOldPointerSpace(Object*) here.

Done.

https://codereview.chromium.org/23606032/diff/1/src/objects.cc#newcode9040
src/objects.cc:9040: object->GetHeap()->Contains(site_address)) {
On 2013/09/16 16:12:05, Hannes Payer wrote:
> Instead of checking the whole heap, you could check if the address is in old
> pointer space since this is the place where allocation sites should be
> allocated.

Done.

[mvstanton, 2013-09-16 16:40:48]

Hi Hannes, here is the code we discussed. Michael, would you take a quick look
at the Heap::Contains() call in objects.cc?
thx,
--Michael

[Hannes Payer (out of office), 2013-09-16 16:49:22]

LGTM

[mvstanton, 2013-09-16 16:50:54]

Committed patchset #3 manually as r16742 (presubmit successful).